Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch IRC urls from irc2go.com / irc.openstreetmap.org -> webchat.oftc.net #136

Closed
harry-wood opened this issue May 8, 2018 · 10 comments
Closed
Labels
good first issue Good for newcomers

Comments

@harry-wood
Copy link
Contributor

harry-wood commented May 8, 2018

We have some links to irc2go.com. D'you think we should link irc.openstreetmap.org instead?

There's a URL trick for doing this. The chan parameter sets that form value. So for example instead of http://en.irc2go.com/webchat/?net=OFTC&room=osm-gb we'd link https://irc.openstreetmap.org/?chan=osm-gb

I think it would be better for a couple of reasons. 1) I suppose being on a "openstreetmap.org" domain looks more professional/reassuring. 2) irc2go (links like this http://en.irc2go.com/webchat/?net=OFTC&room=osm-gb ) tries to launch a java applet, and who uses java applets these days? (I seem to have managed to browse the web for four months on a new laptop without ever needing to, so this link basically doesn't work for me unless I do some horrible set-up process)

@bhousel
Copy link
Member

bhousel commented May 8, 2018

Sure, switching to irc.openstreetmap.org seems ok.

@bhousel bhousel closed this as completed in 366f9a6 May 8, 2018
@harry-wood
Copy link
Contributor Author

I was noticing today that the chan parameter doesn't actually work. It looks like it's working (so much so that we didn't notice the problem) bit it goes on to connect you to the default #osm channel.

Seems like a bug in cgiirc which I've reported here: dgl/cgiirc#12

@bhousel
Copy link
Member

bhousel commented Jun 6, 2018

Thanks @harry-wood, I'll reopen until the issue is fixed upstream..

@bhousel bhousel reopened this Jun 6, 2018
@ghost
Copy link

ghost commented Jun 10, 2018

Can't you just use https://webchat.oftc.net/?channels=osm-gb instead? Works fine

@harry-wood
Copy link
Contributor Author

Lack of response upstream from the cgiirc developers, so that's annoying. I think we should fork the landing page form and make it more OpenStreetMap-styled anyway, so that could be the ultimate solution.

In the meantime @FredrikLindseth 's suggestion seems good. There's something nice and "native" about linking to the people that actually host the IRC channels, and they have a webchat interface with working channel links! That's cool. Didn't know about it.

@bhousel bhousel added the good first issue Good for newcomers label Aug 26, 2018
@bhousel
Copy link
Member

bhousel commented Sep 27, 2018

Tagged this is a good first issue for anyone who wants to contribute. Task here would be to replace any current irc2go.com or irc.openstreetmap.org links with webchat.oftc.net links.

@techac
Copy link

techac commented Oct 3, 2018

can I work on this issue. As I am new to this project can you please specifically tell exactly what part of codebase should I work on?
Thanks..

@harry-wood
Copy link
Contributor Author

Welcome! Look at the JSON data files under 'resources'. It's going to look quite similar to this commit: 366f9a6 but changing the URLs again.

@techac
Copy link

techac commented Oct 3, 2018

OK you want me to replace irc2.go.com or irc.openstreetmap.org links with webchat.oftc.net links?
And no need to disturb other links (facebook, twitter) and also what about links.openstreetmap.org

@bhousel bhousel changed the title IRC resources. irc2go.com -> irc.openstreetmap.org Switch IRC urls from irc2go.com / irc.openstreetmap.org -> webchat.oftc.net Oct 3, 2018
@bhousel
Copy link
Member

bhousel commented Oct 3, 2018

Yes @techac - You'll need to search all the code under /resources/* to find the links.. No need to touch anything other than irc2.go.com and irc.openstreetmap.org.

The task here is to upgrade those existing IRC urls to look like this:
https://webchat.oftc.net/?channels=osm

(note the channels= param replaces whatever those other services use to open their irc channel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants