Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More predictable output names #43

Open
supakeen opened this issue Jan 6, 2025 · 2 comments
Open

More predictable output names #43

supakeen opened this issue Jan 6, 2025 · 2 comments
Labels
🪄 enhancement New feature or request

Comments

@supakeen
Copy link
Member

supakeen commented Jan 6, 2025

When building an image like so:

sudo podman run --privileged \                
   -v ./output:/output \
   ghcr.io/osbuild/image-builder-cli:latest \
   build \
   --distro fedora-41 \
   minimal-raw

I can predict part of the result path, currently it'll be output/$distro-$release-$imagetype-$arch however, the path parts that come after that are unpredictable as they are xz/disk.raw.xz.

Perhaps we can make them more predictable by outputting:

output/$distro-$release-$imagetype-$arch.raw.xz

instead?

@supakeen supakeen added the 🪄 enhancement New feature or request label Jan 6, 2025
This was referenced Jan 6, 2025
@mvo5
Copy link
Collaborator

mvo5 commented Jan 6, 2025

Thank you! There are some hard-coded pieces in the image library currently around filenames, it would be nice to be more flexible here, some discussion is here osbuild/images#1039 - another source of hardcoding is osbuild itself that always creates the pipeline dir as prefix (c.f. https://github.com/osbuild/osbuild/blob/v137/osbuild/main_cli.py#L57)

@supakeen
Copy link
Member Author

supakeen commented Jan 6, 2025

Perhaps we can take this together with (an expanded) version of osbuild/osbuild#1930 so we know which files to expect where and then move them into friendlier paths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants