Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib: use plain squashfs for the ISO rootfs #777

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Jan 6, 2025

This commit moves to the new "flat" squashfs rootfs image
that is now available in the images library (c.f.
osbuild/images#1105).

This will ensures we are no longer using the previous "ext4"
intermediate image that gave problems for big rootfses.

Closes: #733

@mvo5 mvo5 force-pushed the iso-squashfs-rootfs branch 2 times, most recently from 4cd30c8 to bc6d39f Compare January 6, 2025 11:29
@mvo5 mvo5 changed the title bib: generate intermediate image via squasfs bib: generate intermediate image via squashfs Jan 6, 2025
@mvo5 mvo5 force-pushed the iso-squashfs-rootfs branch 2 times, most recently from 6662315 to f796877 Compare January 6, 2025 12:11
@mvo5 mvo5 changed the title bib: generate intermediate image via squashfs bib: use plain squashfs for the ISO rootfs Jan 6, 2025
@mvo5 mvo5 marked this pull request as ready for review January 6, 2025 12:11
@mvo5 mvo5 requested a review from ondrejbudai January 6, 2025 12:12
ondrejbudai
ondrejbudai previously approved these changes Jan 6, 2025
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

ondrejbudai
ondrejbudai previously approved these changes Jan 8, 2025
@ondrejbudai
Copy link
Member

ondrejbudai commented Jan 8, 2025

There's now a conflict. :/

mvo5 added 2 commits January 8, 2025 10:39
This commit moves to the new "flat" squashfs rootfs image
that is now available in the `images` library (c.f.
osbuild/images#1105).

This will ensures we are no longer using the previous "ext4"
intermediate image that gave problems for big rootfses.

Closes: osbuild#733
@mvo5
Copy link
Collaborator Author

mvo5 commented Jan 8, 2025

There's no a conflict. :/

Indeed, oh well - fixed now :)

@mvo5 mvo5 requested a review from ondrejbudai January 8, 2025 09:41
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go!

@mvo5 mvo5 added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 8, 2025
@mvo5 mvo5 added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@mvo5 mvo5 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into osbuild:main with commit 6f863bc Jan 8, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIB failed to create centos9s anaconda-iso : No space left on device
2 participants