-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bib: use plain squashfs for the ISO rootfs #777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
iso-squashfs-rootfs
branch
2 times, most recently
from
January 6, 2025 11:29
4cd30c8
to
bc6d39f
Compare
mvo5
changed the title
bib: generate intermediate image via squasfs
bib: generate intermediate image via squashfs
Jan 6, 2025
mvo5
commented
Jan 6, 2025
mvo5
force-pushed
the
iso-squashfs-rootfs
branch
2 times, most recently
from
January 6, 2025 12:11
6662315
to
f796877
Compare
mvo5
changed the title
bib: generate intermediate image via squashfs
bib: use plain squashfs for the ISO rootfs
Jan 6, 2025
ondrejbudai
previously approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks!
mvo5
force-pushed
the
iso-squashfs-rootfs
branch
from
January 6, 2025 20:26
f796877
to
005427c
Compare
mvo5
force-pushed
the
iso-squashfs-rootfs
branch
from
January 7, 2025 08:48
005427c
to
9d912a5
Compare
ondrejbudai
previously approved these changes
Jan 8, 2025
There's now a conflict. :/ |
This commit moves to the new "flat" squashfs rootfs image that is now available in the `images` library (c.f. osbuild/images#1105). This will ensures we are no longer using the previous "ext4" intermediate image that gave problems for big rootfses. Closes: osbuild#733
mvo5
force-pushed
the
iso-squashfs-rootfs
branch
from
January 8, 2025 09:40
9d912a5
to
e2acfa8
Compare
Indeed, oh well - fixed now :) |
ondrejbudai
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves to the new "flat" squashfs rootfs image
that is now available in the
images
library (c.f.osbuild/images#1105).
This will ensures we are no longer using the previous "ext4"
intermediate image that gave problems for big rootfses.
Closes: #733