Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier output paths and file names #247

Closed
achilleas-k opened this issue Mar 7, 2024 · 1 comment
Closed

Friendlier output paths and file names #247

achilleas-k opened this issue Mar 7, 2024 · 1 comment

Comments

@achilleas-k
Copy link
Member

File names and extensions could be more predictable and friendlier if we use image type names and the container name.
We can use the image name as a basename for the disk files and the image type as the extension. Note that raw and ami are identical, so it might be wasteful to allow users to specify --type raw --type ami, build one image and copy it out as two files (which could be tens of GiB in size each).
The subdirectory in the output dir is, currently, the exported pipeline name because we take it directly from osbuild's output, but we should put it all in the same subdir (or a subdir matching the image type name).

I want the images that are output named to match the image name or let me name the image. I was thinking that
BIB quay.io/podman/foobar --type ami --type raw --type hperv --type qcow I would end up with a directory tree of

raw/roobar.raw
ami/foobar.ami
hyperv/foobar.hyperv
qcow2/foobar.qcow2

OR

image/roobar.raw
image/foobar.ami
image/foobar.hyperv
image/foobar.qcow2

From a user perspective, I like the second one best, but either can be worked with.

Originally posted by @rhatdan in #225 (comment)

@ondrejbudai
Copy link
Member

Duplicate of #103

@ondrejbudai ondrejbudai marked this as a duplicate of #103 Mar 20, 2024
@ondrejbudai ondrejbudai closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants