Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultSigner should support key rotation #786

Open
3 of 5 tasks
mitar opened this issue Jan 26, 2024 · 3 comments
Open
3 of 5 tasks

DefaultSigner should support key rotation #786

mitar opened this issue Jan 26, 2024 · 3 comments
Labels
feat New feature or request.

Comments

@mitar
Copy link
Contributor

mitar commented Jan 26, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

It looks to me like there is no simple way to rotate the keypair? DefaultSigner and its GetPrivateKey allows only one key to be returned?

Describe your ideal solution

I think DefaultSigner should also have a method like GetRotatedPrivateKeys which would be used only for validating. Similar to how there is GlobalSecret and RotatedGlobalSecrets.

Workarounds or alternatives

I could implement my own Signer but it would be better if this is part of fosite.

Version

v0.45.0

Additional Context

No response

@mitar mitar added the feat New feature or request. label Jan 26, 2024
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Jan 26, 2025
@mitar
Copy link
Contributor Author

mitar commented Jan 26, 2025

Still relevant.

@github-actions github-actions bot removed the stale Feedback from one or more authors is required to proceed. label Jan 27, 2025
@aeneasr
Copy link
Member

aeneasr commented Jan 28, 2025

I'm quite confident that key rotation works in hydra, so might be worth a look there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants