Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make arc optional #17

Closed
wants to merge 2 commits into from
Closed

Make arc optional #17

wants to merge 2 commits into from

Conversation

stevefan1999-personal
Copy link

fixes #16

@stevefan1999-personal stevefan1999-personal mentioned this pull request Dec 10, 2022
Closed
orium
orium reviewed Dec 11, 2022
View reviewed changes
Cargo.toml
@@ -69,3 +72,4 @@ harness = false
name = "archery_shared_pointer_arc"
path = "benches/archery_shared_pointer_arc.rs"
harness = false
required-features = ["arc"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line in the EOF.

Cargo.toml
fatal-warnings = []
arc = []
Copy link
Owner

@orium orium Dec 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have arc support by default. Can you make this feature a no_arc? (and also remove the required-features for the benchmarks)

@orium orium force-pushed the master branch 2 times, most recently from 06d44a2 to 98e23da Compare October 27, 2023 22:11
@orium
Copy link
Owner

orium commented Oct 27, 2023

Closed due to inactivity.

@orium orium closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orium orium orium left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Arc optional
2 participants
@stevefan1999-personal @orium