The new bottle creation workflow for taps is amazing!

[ladislas]

Hi there! --

A few days ago, I finally had the time to move from Azure Pipelines to the new GA workflow for bottle creation for our tap https://github.com/osx-cross/homebrew-avr

The reference workflow was of great help but I struggled a little bit with the token part when the repo is own by an organization. We have a test bot account so I used this account for the PAT. I had to reference the PAT as a secret for the repository as ${{ github.token }} was not working.

But then, the homebrew/git-setup-step was still referencing me (the PR creator) when I wanted our test bot to be.

In the end, the following fixed the issues -- I don't know if it can be improved, but it works and is simple enough so I won't touch it.

# start with checkout
    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          token: "${{ secrets.OSX_CROSS_AVR_HOMEBREW_GITHUB_API_TOKEN }}"

# [...]

# then just setup git -- much quicker than the action
      - name: Set up git
        run: |
          git config --global user.name "osxCrossTestBot"
          git config --global user.email "[email protected]"

The whole configuration is available here: https://github.com/osx-cross/homebrew-avr/tree/master/.github/workflows

A big thank you for the homebrew team for putting that together and make it so easy for us tap maintainers to provide bottles for our users :)

[Rylan12]

Awesome, glad you find it useful! Huge thanks goes to @dawidd6 for implementing this! 🥳🎉

---

What fails if you don't use the checkout action? I would have thought that setting HOMEBREW_GITHUB_API_TOKEN in env like you did would be sufficient. Homebrew/actions/setup-homebrew should automatically tap your repository based on $GITHUB_REPOSITORY.

For the git setup, I think what you're doing is fine. You can pass a specific user to the Homebrew/actions/git-user-config action which will set the username and email appropriately, but I don't see an issue with what you're doing. It's probably taking longer because it makes an API call to GitHub to determine the email for the given user. You can take a look at the code over in Homebrew/actions/git-user-config if you're curious.

[ladislas]

For the git setup, I think what you're doing is fine. You can pass a specific user to the Homebrew/actions/git-user-config action which will set the username and email appropriately, but I don't see an issue with what you're doing. It's probably taking longer because it makes an API call to GitHub to determine the email for the given user. You can take a look at the code over in Homebrew/actions/git-user-config if you're curious.

Yep, that's what I did (the user and looking at the code) but for some reason, it was still using my username.

What fails if you don't use the checkout action? I would have thought that setting HOMEBREW_GITHUB_API_TOKEN in env like you did would be sufficient.

Not sure now, I'll have to try again. But the workflow takes 5~7 min each time :)

[Rylan12]

Huh... To be honest I'm not sure, then. I don't see any obvious problems with it, though, so if it works as expected I'd say just leave it.