Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Disable Spotlights in Production #5546

Closed
adhiamboperes opened this issue Oct 2, 2024 · 5 comments
Closed

[BUG]: Disable Spotlights in Production #5546

adhiamboperes opened this issue Oct 2, 2024 · 5 comments
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Oct 2, 2024

Describe the bug

In the recently release beta 0.13, spotlights are enabled, when they should not be.

Steps To Reproduce

  • Install the beta app via Playstore.
  • Login to profile
  • Spotlights will be shown
  • Select a topic to play
  • More spotlights are shown

Expected Behavior

Spotlights should not be shown as it is an alpha-only feature.

Screenshots/Videos

oppia_new_spotlights_background_lighter.mp4

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

0.13-beta

Additional Context

No response

@adhiamboperes adhiamboperes added bug End user-perceivable behaviors which are not desirable. triage needed Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed triage needed labels Oct 2, 2024
@Vinay-Khanagavi
Copy link

Can you provide the screenshot of spotlights

@Vinay-Khanagavi
Copy link

@adhiamboperes! It seems like a flag might have slipped through during the beta release process.

I'll take a look at the code and make sure spotlights are only enabled for alpha builds going forward. 👍

@adhiamboperes adhiamboperes self-assigned this Dec 3, 2024
@BenHenning
Copy link
Member

BenHenning commented Dec 29, 2024

Confirming that I apparently enabled this in FeatureFlagConstants per my local release-0.13 directory. Going to send a change to fix this 'properly' by gating it on alpha only builds.

Thanks for reporting @adhiamboperes.

Also: note that this will be automatically fixed on the next release of the app since we won't have it enabled for beta builds (and I'll double check that they are off for beta).

@BenHenning
Copy link
Member

This should be fixed in the latest version of the app. Thanks again for filing this @adhiamboperes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

3 participants