From 53736bf10f02d287efd7e52c6215e7693ada46ee Mon Sep 17 00:00:00 2001 From: Alexander Brandon Coles Date: Fri, 24 Jan 2025 18:55:52 -0300 Subject: [PATCH] Replace invalid octal escape sequences in RegEx TypeScript 5.5 introduces syntax checking for regexen. See: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#regular-expression-syntax-checking --- .../frontend/module/git-actions/git-actions.service.ts | 4 ++-- .../frontend/module/git-actions/git-actions.service.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/github_integration/frontend/module/git-actions/git-actions.service.ts b/modules/github_integration/frontend/module/git-actions/git-actions.service.ts index 21fdb96322c8..eeece1315e5d 100644 --- a/modules/github_integration/frontend/module/git-actions/git-actions.service.ts +++ b/modules/github_integration/frontend/module/git-actions/git-actions.service.ts @@ -38,8 +38,8 @@ export class GitActionsService { return str .replace(/&/g, 'and ') // & becomes and .replace(/ +/g, '-') // Spaces become dashes - .replace(/[\000-\039]/g, '') // ASCII control characters are out - .replace(/\177/g, '') // DEL is out + .replace(/[\x00-\x1F]/g, '') // ASCII control characters are out + .replace(/\x7F/g, '') // DEL is out .replace(/[#\\\/\?\*\~\^\:\{\}@\.\[\]'"]/g, '') // Some other characters with special rules are out .replace(/^[-]+/g, '') // Dashes at the start are removed .replace(/[-]+$/g, '') // Dashes at the end are removed diff --git a/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts b/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts index d79af424e529..e08d336b4e73 100644 --- a/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts +++ b/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts @@ -41,8 +41,8 @@ export class GitActionsService { return str .replace(/&/g, 'and ') // & becomes and .replace(/ +/g, '-') // Spaces become dashes - .replace(/[\000-\039]/g, '') // ASCII control characters are out - .replace(/\177/g, '') // DEL is out + .replace(/[\x00-\x1F]/g, '') // ASCII control characters are out + .replace(/\x7F/g, '') // DEL is out .replace(/[#\\\/\?\*\~\^\:\{\}@\.\[\]'"]/g, '') // Some other characters with special rules are out .replace(/^[-]+/g, '') // Dashes at the start are removed .replace(/[-]+$/g, '') // Dashes at the end are removed