Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform code cleanups #21

Open
kthoms opened this issue Dec 11, 2024 · 0 comments
Open

Perform code cleanups #21

kthoms opened this issue Dec 11, 2024 · 0 comments
Labels
good first issue Good for newcomers refactoring Code enhancement without changing API or behaviour

Comments

@kthoms
Copy link
Contributor

kthoms commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
The code base has grown and contains patterns that can be safely refactored. The code style should be modern and clean.

Describe the solution you'd like

  • Use Open Rewrite recipes and apply them on the code base. One module per Pull Request and applied recipe.
  • Look up build warnings of the IDE for patterns. Resolve warnings per identified pattern (e.g. unnecessary type qualifiers)
@kthoms kthoms added good first issue Good for newcomers refactoring Code enhancement without changing API or behaviour labels Dec 11, 2024
kthoms added a commit that referenced this issue Dec 11, 2024
@kthoms
refactor(deprecation): Replace StringUtils#isEmpty() by `ObjectUtil…
4b1bf85 
…s.isEmpty()`

Refactored with OpenRewrite recipe org.openrewrite.java.spring.framework.UseObjectUtilsIsEmpty

related to #21
@kthoms kthoms mentioned this issue Dec 11, 2024
Merged
kthoms added a commit that referenced this issue Dec 11, 2024
@kthoms
refactor(deprecation): Replace StringUtils#isEmpty() by `ObjectUtil…
011d5fd 
…s.isEmpty()` (#22)

Refactored with OpenRewrite recipe org.openrewrite.java.spring.framework.UseObjectUtilsIsEmpty

related to #21
@kthoms kthoms mentioned this issue Dec 20, 2024
Merged
kthoms added a commit that referenced this issue Dec 20, 2024
@kthoms
chore: format .java files
cdc406f 
The code had a mixture of tabs/spaces.

Reformatted once with spaces and 2 space indent.

related to #21
@kthoms kthoms mentioned this issue Dec 20, 2024
Merged
kthoms added a commit that referenced this issue Dec 20, 2024
@kthoms
chore: format .java files
32609e7 
The code had a mixture of tabs/spaces.

Reformatted once with spaces and 2 space indent.

related to #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring Code enhancement without changing API or behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kthoms