Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release archive #2454

Closed
plorenz opened this issue Sep 27, 2024 · 1 comment · Fixed by #2457
Closed

Fix release archive #2454

plorenz opened this issue Sep 27, 2024 · 1 comment · Fixed by #2457
Assignees
@plorenz

Comments

@plorenz
Copy link
Member

plorenz commented Sep 27, 2024

Release archive now includes extra test binary
@plorenz plorenz self-assigned this Sep 27, 2024
plorenz added a commit that referenced this issue Sep 27, 2024
@plorenz
Don't build shaper test binary. Fixes #2454
a5b7971
@qrkourier
Copy link
Member

The other issue was the unexpected "Ziti"dir enclosing the binary. It was that way a few releases ago, then we switched to a naked binary without an enclosing directory, and 13 switched it back, reportedly.

plorenz added a commit that referenced this issue Sep 28, 2024
@plorenz
Don't build shaper test binary. Fixes #2454
98c7237
plorenz added a commit that referenced this issue Sep 30, 2024
@plorenz
Don't build shaper test binary. Fixes #2454
e2aa2d2
@qrkourier qrkourier linked a pull request Sep 30, 2024 that will close this issue
Don't build shaper test binary. Fixes #2454 #2457
Merged
plorenz added a commit that referenced this issue Sep 30, 2024
@plorenz
Merge pull request #2457 from openziti/fix-release
1e0388e 
Don't build shaper test binary. Fixes #2454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plorenz plorenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't build shaper test binary. Fixes #2454 openziti/ziti
2 participants
@plorenz @qrkourier