Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow router to decomission itself #1402

Closed
plorenz opened this issue Jun 6, 2023 · 4 comments · Fixed by #1568
Closed

Allow router to decomission itself #1402

plorenz opened this issue Jun 6, 2023 · 4 comments · Fixed by #1568
Labels
enhancement New feature or request fabric Issue is related to fabric level functionality

Comments

@plorenz
Copy link
Member

plorenz commented Jun 6, 2023

Add a ziti agent router decomission that will ask the controller to delete the router out of the model. Useful in autoscaling setups when scaling down.

Can be used in conjunction with quiesce, see openziti/fabric#538

@plorenz plorenz transferred this issue from openziti/fabric Oct 4, 2023
@plorenz plorenz added enhancement New feature or request fabric Issue is related to fabric level functionality labels Oct 4, 2023
@dariuszSki
Copy link
Contributor

@plorenz any idea when would this be implemented?

@plorenz
Copy link
Member Author

plorenz commented Dec 6, 2023

@plorenz any idea when would this be implemented?

I was in this area of the code, so I implemented this today. Note that this will only be the decomission portion. Will still need #1400 and/or #1425 to make it graceful.

@Russell-Allen
Copy link

Does decommissioning a router result in the router being deleted from the controller, or does it just change the state of the router such that it is not used for new sessions/circuits? Can a decommissioned router be recommissioned?

How aggressive is the decommissioning process? Does it force existing circuits to reroute, or is it 'soft' and just prevents new usage of the router?

@plorenz
Copy link
Member Author

plorenz commented Dec 11, 2023

Does decommissioning a router result in the router being deleted from the controller, or does it just change the state of the router such that it is not used for new sessions/circuits? Can a decommissioned router be recommissioned?

How aggressive is the decommissioning process? Does it force existing circuits to reroute, or is it 'soft' and just prevents new usage of the router?

It's intended for use in scale-up/scale-down, so the router will get deleted. It's intended to be as part of a larger set of operations.

There's already a quiesce operation, which will mark all terminators as failed. That will allow existing circuits to complete, but will only create new circuits on that router if it's the only available option.

There still one piece not yet implemented, which is a way to check for active circuits on the router. In the end, the flow would look something like:

quiesce
wait for circuit count to drop to 0, with some timeout
decomission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fabric Issue is related to fabric level functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants