-
Notifications
You must be signed in to change notification settings - Fork 344
Add TCK #278
Comments
TCK? |
Test suite to verify correct tracer implementation. |
Guess that's something similar to the |
It would likely need to be far more specific than the harness in python or the go port which is not much more than a compile test. Since OpenTracing doesn't provide a stable implementation, yet expects people to use unknown implementations, the TCK should be more strict like https://github.com/reactive-streams/reactive-streams-jvm/tree/master/tck For example, it should verify things such as thread behavior. Even better to ensure the tracer doesn't block or becomes unloadable due to implementation problems. Most importantly, the features supported should be verifiable. For example, baggage, KV logging, etc. This may be tricky for agents because very few will be using opentracing underneath, or exposing a "native" opentracer. This could imply some setup interest for example a runner that can affect the JVM launch parameters. Above all, please engage the reactive streams TCK designers especially those who directly or indirectly support OT as they not only know how to do this, but probably their experience cost a long time to accrue.. IOTW, this should be done in a serious fashion by experts or by expert advice. |
Implement TCK to verify correct tracer behavior.
The motivation is for example to avoid issues like #267 (comment). For example brave-ot implements OpenTracing but
SpanManager.active().close()
is noop.The text was updated successfully, but these errors were encountered: