Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Screen Sharing changes #457

Closed
rrnara opened this issue Nov 5, 2020 · 4 comments
Closed

Android Screen Sharing changes #457

rrnara opened this issue Nov 5, 2020 · 4 comments

Comments

@rrnara
Copy link

rrnara commented Nov 5, 2020

I have changes here which allow sharing screen even when outside the app, it would be helpful if it is actually merged here instead. Can anyone review/merge it?

master...rrnara:master

@enricop89
Copy link
Contributor

@rrnara can you open a Pull Request please?

@rrnara
Copy link
Author

rrnara commented Nov 6, 2020

I don't seem to have permissions to push to a branch, which is why asking if someone can do it

@enricop89
Copy link
Contributor

You need to fork the repo and push the branch :) Instructions here: https://github.com/opentok/opentok-react-native/blob/master/CONTRIBUTING.md

@rrnara rrnara mentioned this issue Nov 6, 2020
2 tasks
@rrnara
Copy link
Author

rrnara commented Nov 6, 2020

Thanks, created a PR here: #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants