Disable edit actions on save screen

[danieldegroot2]

URL

No response

How to reproduce the issue?

• Disallow adding nodes to ways on save screen (prevent accidental redundant nodes)
• Cancel dragging on save (prevent accidental drag); note, completing drag on active view edge causes infinite map view drag.
  (while dragging, use Ctrl+S to go to the save screen);
  For some reason, this bug never happens when dragging the first node of a way.

There might be other actions which are undesirable.
Rapid does not allow these actions on save, but completes -not cancels- drag, resulting in accidental drag.

See also #10593 (only the action where node is still 'hovering' -not placed down yet- should be cancelled, not the whole line)

Screenshot(s) or anything else?

Infinite map view drag (node is placed down but stuck to sidebar, map view is stuck moving, even with save cancelled, ESC, Ctrl+Z..
Only happens while in save screen.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid

What version numbers does this issue effect?

2.30.4, 2.31.0-dev, Rapid 2.5.0

Which browsers are you seeing this problem on?

Chrome

[tyrasd]

I don't really understand the issue. In the "save"/upload dialog, all editing should be disabled. Your screenshot seems to show the normal edit menu, not the save screen. Can you please explain in a little more detail how to trigger the bug?

PS: It would be helpful if you could submit screenshots in English locale (e.g. by using the dev preview instance of iD: https://ideditor.netlify.app/#locale=en)

[danieldegroot2]

(while dragging, use Ctrl+S to go to the save screen)
as already mentioned;

1. Create a new line or select an existing way.
2. Drag a node to the left sidebar (so you are hovering over/under the scrollbar), so the map view starts to move to the left.
3. While not letting go of the node, press Ctrl+S.
4. Node drag is 'cancelled' on save; node is placed down, which cancels the save screen, which is why it is back into edit mode.
   However, the node is still visually stuck to the sidebar and the application still thinks it is dragging to the left, keeps doing so.

PS: It would be helpful if you could submit screenshots in English locale (e.g. by using the dev preview instance of iD: https://ideditor.netlify.app/#locale=en)

Drag node to left

Press Ctrl+S (save screen is instantly cancelled as mentioned, so there is no screenshot of a save screen.)

[tyrasd]

Ok, thanks! 🙇

I'm not sure how often mappers press Ctrl+S while dragging a node, but it's still something we should address. Interestingly, it does not happen when one drags a node using the edit menu (or M keyboard shortcut) on a vertex. 🤷