Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload changesets when an element in a relation whose type has a prefix is edited #10649

Open
Swarkin opened this issue Jan 3, 2025 · 4 comments
Labels
bug A bug - let's fix this!

Comments

@Swarkin
Copy link

Swarkin commented Jan 3, 2025

Description

When editing an element that is a member of a relation which is tagged with for example disused:type=, both iD and Rapid refuse to upload it even though there have not been any edits to these relations as it doesn't detect the type field.

Screenshots

https://i.imgur.com/bkGV0tD.png

@mibe
Copy link

mibe commented Jan 4, 2025

Here is the changeset causing this issue. AFAIK the error message pops up even if no relation tags were changed. For example, AFAIK splitting a way which is a member of the causing relation is enough for triggering this error.

Background: We got completely new bus lines at the turn of the year. IMHO it was/is not feasible to adapt the change to the old route relations because the change is so significant, that just creating new relations is quicker and easier. But I did not delete the old relations yet, because I wanted to still have them for reference while creating the new relations. So I deactived the relations by adding the disused: prefix to the type=route and route=bustags of the relation.

@k-yle
Copy link
Collaborator

k-yle commented Jan 6, 2025

According to the wiki1, a relation must have the type tag, so I believe this behaviour is intentional.

type=route + disused:route=bus would be a valid alternative.

Footnotes

  1. https://osm.wiki/Relation#:~:text=A%20relation%20element%20must%20have%20at%20least%20the%20type=*%20tag

@tyrasd tyrasd added bug A bug - let's fix this! wontfix-not-a-bug Not actually a bug and removed bug A bug - let's fix this! labels Jan 7, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2025

What @k-yle says ☝️

@tyrasd tyrasd closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
@tyrasd tyrasd reopened this Jan 7, 2025
@tyrasd tyrasd added bug A bug - let's fix this! and removed wontfix-not-a-bug Not actually a bug labels Jan 7, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2025

That said, iD should not prevent a user from uploading a change that does not directly modify an existing relation without a type tag: e.g. to reproduce:

--

For reference: There are currently about 2k relations without a type tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

4 participants