Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semiCombo does not support duplicate values #10635

Open
k-yle opened this issue Dec 30, 2024 · 2 comments · May be fixed by ideditor/schema-builder#178, #10639 or openstreetmap/id-tagging-schema#1418
Open
Labels
field An issue with a field in the user interface

Comments

@k-yle
Copy link
Collaborator

k-yle commented Dec 30, 2024

URL

https://osm.org/edit?way=26229179

How to reproduce the issue?

Fixing this properly will require PRs in 3 different repositories, so I'm creating an issue to keep this organised.

From openstreetmap/id-tagging-schema#1065 (comment):

BTW, there's also a bug when entering multiple none values to the destination:symbol key. If we add two of more none values separated with ; iD only considers one. And if you grab and move one of those none values, iD eliminates all of them and leaves only one in the value part of the tag.

This bug/limitation also affects *:lanes:*, seamark:*:colour, as well as destination:*, where values like …;none;none;… or red;white;red are acceptable.

Screenshot(s) or anything else?

Untitled

Which deployed environments do you see the issue in?

No response

What version numbers does this issue effect?

all

Which browsers are you seeing this problem on?

Microsoft Edge

@tordans
Copy link
Collaborator

tordans commented Dec 30, 2024

What is the order that those PRs need to be merged/released in?

Is there maybe some guarding that we should/can add to allow to untangle them? Something like checking for 'if "allowDuplicates" in preset' in iD?

@k-yle
Copy link
Collaborator Author

k-yle commented Dec 30, 2024

ideditor/schema-builder#178 has to go first (also because there might be code review suggestions to rename the field)

for the other two PRs the order doesn't matter. older versions of iD will simply ignore the new field

@tyrasd tyrasd added the field An issue with a field in the user interface label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface
Projects
None yet
3 participants