Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bridge or tunnel should not suffice to stop warnings about crossing ways #10631

Open
jleedev opened this issue Dec 25, 2024 · 1 comment
Open
Labels
considering Not Actionable - still considering if this is something we want

Comments

@jleedev
Copy link
Contributor

jleedev commented Dec 25, 2024

URL

No response

How to reproduce the issue?

  1. Draw two crossing ways, one with highway=residential and bridge=yes, one with waterway=river.
  2. Draw two crossing ways with different layer but neither bridge nor tunnel.

Actual:

Neither is caught by the validator.

Expected:

1 should be flagged: With the noted exceptions of indoor/corridor/building/etc, crossing ways (highway, waterway, railway) having the same layer is never correct: They should either intersect or have different layers.
2 should be flagged: If two highway/waterway/railway ways cross each other, it's a virtual certainty that one is a bridge or tunnel. Tagging just the layer is not enough.

Screenshot(s) or anything else?

Having a bridge at layer=0 cross a non-bridge at layer=0 may seem unambiguous, but it confuses rendering. Screenshots near https://www.openstreetmap.org/changeset/160586698 with Tracestrack Topo:

Screenshot 2024-12-25 15 19 02Screenshot 2024-12-25 15 18 57Screenshot 2024-12-25 15 18 53Screenshot 2024-12-25 15 18 49

The sidewalk has layer=1; the highway has layer=0; the sidewalk casing obscures the roadway.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid

What version numbers does this issue effect?

2.31.0

Which browsers are you seeing this problem on?

No response

@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2025

for reference, this is from the wiki:

Bridges should have a layer=*, for simple crossings almost always layer=1 but other values may be appropriate for complex crossings.

(iD automatically adds layer=1 for newly tagged bridges using the field in the presets.)

It is however not that uncommon to see ways with bridge=* and no layer tag (about 7%), so making the validation more strict would potentially lead to many warnings that are not necessarily "problematic situations" (one could argue that a bridge could imply a layer=1 value). 🤔 Perhaps situations like this would be better accounted for in an external quality assurance tool?!

@tyrasd tyrasd added the considering Not Actionable - still considering if this is something we want label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

No branches or pull requests

2 participants