Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit disambiguator from relation type in member/membership editor #8759

Open
1ec5 opened this issue Oct 19, 2021 · 6 comments · May be fixed by #10583
Open

Omit disambiguator from relation type in member/membership editor #8759

1ec5 opened this issue Oct 19, 2021 · 6 comments · May be fixed by #10583
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! usability An issue with ease-of-use or design

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 19, 2021

This way is a member of a few bus routes that are part of the VTA network. Since there are multiple VTA networks, this network is glossed as “Santa Clara Valley Transportation Agency”, which is very long. iD lists the relation membership with a relation type so long that the relation’s actual ref and name get crowded out:

vta

NSI has a convention of putting disambiguating glosses in parentheses, and there doesn’t seem to be any mechanism for a localization to use anything other than parentheses for the disambiguator. The raw member and membership editors could strip out the disambiguator to save space. In this context, the user is more likely to know which VTA it is anyways.

iD/modules/ui/sections/raw_membership_editor.js

Lines 345 to 346 in 19c9524

var matched = presetManager.match(d.relation, context.graph());
return (matched && matched.name()) || t('inspector.relation');

@1ec5 1ec5 added the usability An issue with ease-of-use or design label Oct 19, 2021
@bhousel
Copy link
Member

bhousel commented Oct 19, 2021

I'm probably just going to put the preset icons here at some point, then then names won't matter as much. The relationship membership component could be a lot nicer to look at.

@1ec5 1ec5 added the new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! label Oct 15, 2024
@draunger
Copy link
Contributor

draunger commented Nov 3, 2024

Hey @bhousel @1ec5 is this issue still going on (active) ?

@Deeptanshu-sankhwar Deeptanshu-sankhwar linked a pull request Dec 5, 2024 that will close this issue
Open
@Deeptanshu-sankhwar
Copy link
Contributor

Hi @1ec5 @bhousel , I have reproduced and raised a PR for this issue which uses regex to eliminate any disambiguators in parentheses of relation names. Kindly share your thoughts about it!
Thanks
Screenshot 2024-12-04 at 6 17 09 PM

@Ravish990
Copy link

If the issue is still active then I would love to solve it . It would be great while solving as I am having a sharp interest in open source.

@Deeptanshu-sankhwar
Copy link
Contributor

I am still working on it @Ravish990

@Ravish990
Copy link

@Deeptanshu-sankhwar All the best👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! usability An issue with ease-of-use or design
Projects
None yet
Milestone
No milestone
5 participants
@bhousel @1ec5 @Deeptanshu-sankhwar @draunger @Ravish990