Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated parameters for provisioning #82

Open
mrgunior opened this issue Aug 12, 2019 · 1 comment
Open

Deprecated parameters for provisioning #82

mrgunior opened this issue Aug 12, 2019 · 1 comment

Comments

@mrgunior
Copy link
Contributor

mrgunior commented Aug 12, 2019

Branch: dev
File: provision.go

This test case for organization_guid:

Convey("should reject if request payload is missing organization_guid", func() {
	tempBody := openapi.ServiceInstanceProvisionRequest{}
	deepCopy(req, &tempBody)
	tempBody.OrganizationGuid = ""
	_, resp, err := cli.ServiceInstancesApi.ServiceInstanceProvision(
		authCtx, CONF.APIVersion, instanceID, tempBody,
		&openapi.ServiceInstanceProvisionOpts{AcceptsIncomplete: optional.NewBool(async)})

	So(err, ShouldNotBeNil)
	So(resp.StatusCode, ShouldEqual, 400)
})

And this one for space_guid:
Convey("should reject if request payload is missing space_guid", func() {
	tempBody := openapi.ServiceInstanceProvisionRequest{}
	deepCopy(req, &tempBody)
	tempBody.SpaceGuid = ""
	_, resp, err := cli.ServiceInstancesApi.ServiceInstanceProvision(
		authCtx, CONF.APIVersion, instanceID, tempBody,
		&openapi.ServiceInstanceProvisionOpts{AcceptsIncomplete: optional.NewBool(async)})

	So(err, ShouldNotBeNil)
	So(resp.StatusCode, ShouldEqual, 400)
})

These two parameters have been replaced with the parameter context (which is optional) in version 2.11 of the OSBAPI. Are they still necessary according to the current specifications?

@leonwanghui
Copy link
Collaborator

@mrgunior If you look at the spec, currently the organization_guid and space_guid fields are still required for request to provision an instance, I believe it's designed to be back-compatible with former version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

2 participants