Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of validation checks in OSB API #30

Open
subhankarc opened this issue Mar 16, 2018 · 4 comments
Open

Order of validation checks in OSB API #30

subhankarc opened this issue Mar 16, 2018 · 4 comments

Comments

@subhankarc
Copy link

In case of async parameter check, this code sends an empty body and it does not send the accept_incomplete parameter in query.

Service Fabrik broker which checks for the mandatory parameters first, will send a Bad Request for the same and hence the test fails as the test expects Unprocessable Entity(422) error.

Is there a defined order of checks the broker has to do? If not, then the test should be enhanced.

@duglin
Copy link

duglin commented Mar 16, 2018

+1 spec does not mandate an order

@sauravmndl-zz
Copy link

@duglin Thanks for your input. Would helpful if the fix is incorporated to the tool ASAP, as we have already made our service broker OSB API compliant. Want to use/rely on this tool for our API check.

@leonwanghui
Copy link
Collaborator

Hi @subhankarc , from my perspective, there could be other errors rather than missing accept_incomplete parameter for your case. Normally when we check if accept_incomplete parameter misses, we would make sure all other potential errors resolved (all mandatory parameters should be matched in your case), so I suggest you could give more details about how your broker checks the mandatory parameters, thanks!

@leonwanghui
Copy link
Collaborator

@zhongyi-zhang @norshtein Is there something we can do to fix this gap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

4 participants