Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint fails with 100+ errors #42

Open
jamescrowley opened this issue Sep 18, 2024 · 1 comment
Open

eslint fails with 100+ errors #42

jamescrowley opened this issue Sep 18, 2024 · 1 comment
Labels

Comments

@jamescrowley
Copy link

jamescrowley commented Sep 18, 2024

eslint has a tonne of errors currently (mostly, but not exclusively no-unused-vars). Prettier/format also needed to be run on a bunch of outlook.json files already committed to the repo (which may just make sense to be excluded from prettier?). Flagging this as I tripped over it with my work on #32.

Perhaps it would make sense to add a GitHub action that both runs the tests that will now be present, and also enforce linting/formatting?

@chienleng
Copy link
Member

the current state of the front end needs a bit of a tidy up before adding GitHub action to enforce any linting and formatting. I will try and get some time hopefully in the next few months to do this.

though this shouldn't prevent writing the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants