Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js macOS release builds fail to codesign #39

Closed
richardlau opened this issue Jan 27, 2025 · 3 comments
Closed

Node.js macOS release builds fail to codesign #39

richardlau opened this issue Jan 27, 2025 · 3 comments
Labels

Comments

@richardlau
Copy link

Contact Details

No response

Description

Refs: nodejs/build#4009

As of 22 Jan 2025, macOS nightly/release builds have started to fail to codesign.

e.g. https://ci-release.nodejs.org/job/iojs+release/10761/nodes=osx13-release-pkg/console

08:59:22 + codesign --sign 'Developer ID Application: Node.js Foundation' --entitlements tools/osx-entitlements.plist --options runtime --timestamp out/macos/dist/x64/node/usr/local/bin/node
08:59:22 error: The specified item could not be found in the keychain.
08:59:22 make: *** [node-v24.0.0-nightly20250122bf59539b98.pkg] Error 1

This blocks any new releases of Node.js on macOS, e.g. Node.js 20.18.3 planned for tomorrow (28 Jan 2025).

Project

Node.js

How urgent is this request?

Critical / Things Are Broken

@richardlau
Copy link
Author

richardlau commented Jan 28, 2025

This blocks any new releases of Node.js on macOS, e.g. Node.js 20.18.3 planned for tomorrow (28 Jan 2025).

Also the proposal for Node.js 23.7.0. (FYI @aduh95)

@ryanaslett
Copy link
Collaborator

Im looking into this currently.

@ryanaslett
Copy link
Collaborator

ryanaslett commented Jan 30, 2025

This should now be fixed. I'll wait until either a release or dailys run to close this issue.

@ryanaslett ryanaslett moved this from In Progress to Done in OpenJS Infrastructure Project Board Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants