Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Potnia: A Python library for the conversion of transliterated ancient texts to Unicode #7450

Closed
editorialbot opened this issue Nov 12, 2024 · 34 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 12, 2024

Submitting author: @etour-unimelb (Emily Tour)
Repository: https://github.com/AncientNLP/potnia.git
Branch with paper.md (empty if default branch): main
Version: v0.3.0
Editor: @arfon
Reviewers: @afrubin, @claresloggett
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258"><img src="https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258/status.svg)](https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258)

Author instructions

Thanks for submitting your paper to JOSS @etour-unimelb. Currently, there isn't a JOSS editor assigned to your paper.

@etour-unimelb if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Nov 12, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (2045.4 files/s, 187381.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            20            348            648           2362
Python                          22            220            220            450
TeX                              2             30              0            297
Markdown                         3             94              0            210
reStructuredText                 7            144             90            167
TOML                             1              7              1             37
DOS Batch                        1              8              1             26
Bourne Shell                     2              4              2             19
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            59            859            969           3577
-------------------------------------------------------------------------------

Commit count by author:

   132	Robert Turnbull
    58	Emily Tour
    38	Kabir Manandhar Shrestha
     7	etour-unimelb
     1	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1628

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@arfon
Copy link
Member

arfon commented Nov 12, 2024

@editorialbot assign me as editor

👋 @samhforbes – I'll take this paper as it's a PyCon AU submission.

@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1162/coli_a_00481 is OK
- 10.1109/MAHC.2024.3351948 is OK
- 10.5281/zenodo.10021513 is OK
- 10.5281/zenodo.5090923 is OK
- 10.18653/v1/P19-1303 is OK
- 10.1145/3593431 is OK
- 10.1073/pnas.2003794117 is OK
- 10.36824/2020-graf-cacc is OK
- 10.1016/j.sbspro.2015.07.415 is OK
- 10.1108/eb026567 is OK
- 10.1080/00437956.1953.11659466 is OK
- 10.21105/joss.04886 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Image and Interpretation: Using Artificial Intelli...
- No DOI given, and none found for title: A Dataset of Mycenaean Linear B Sequences
- No DOI given, and none found for title: Sefaria: A Living Library of Jewish Texts Online
- No DOI given, and none found for title: Transliterating English in Arabic
- No DOI given, and none found for title: Documents in Mycenaean Greek
- No DOI given, and none found for title: Cuneify
- No DOI given, and none found for title: UnicodeConverter
- No DOI given, and none found for title: Anatolian Hieroglyphics (Luwian) generation
- No DOI given, and none found for title: The Ras Shamra Tablet Inventory
- No DOI given, and none found for title: Cuneiform Digital Library Initiative
- No DOI given, and none found for title: DIN 31635: Transliteration of the Arabic alphabet

❌ MISSING DOIs

- None

❌ INVALID DOIs

- doi:10.1515/zac-2020-0018 is INVALID (failed connection)

@arfon
Copy link
Member

arfon commented Nov 12, 2024

@etour-unimelb – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Nov 12, 2024

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Nov 12, 2024
@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

UralicNLP: An NLP Library for Uralic Languages
Submitting author: @mikahama
Handling editor: @gkthiruvathukal (Active)
Reviewers: @gweissman
Similarity score: 0.6503

Inscriptis - A Python-based HTML to text conversion library optimized for knowledge extraction from the Web
Submitting author: @AlbertWeichselbraun
Handling editor: @sbenthall (Active)
Reviewers: @reality, @rlskoeser
Similarity score: 0.6275

teiphy: A Python Package for Converting TEI XML Collations to NEXUS and Other Formats
Submitting author: @jjmccollum
Handling editor: @majensen (Active)
Reviewers: @tresoldi, @SimonGreenhill
Similarity score: 0.6215

Crowsetta: A Python tool to work with any format for annotating animal vocalizations and bioacoustics data.
Submitting author: @NickleDave
Handling editor: @oliviaguest (Active)
Reviewers: @oliviaguest
Similarity score: 0.6214

Phonemizer: Text to Phones Transcription for Multiple Languages in Python
Submitting author: @mmmaat
Handling editor: @danielskatz (Active)
Reviewers: @henrykironde, @chrisbrickhouse
Similarity score: 0.6138

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@rbturnbull
Copy link

@etour-unimelb – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week.

Dear @arfon - thanks for the message. Sorry we didn't respond until now. Yes, the code only has about 425 lines of Python code (in the main package plus tests). But a lot of the work in the project is in the YAML files which tell the package how to run and this is more than 2000 lines of code. We designed it so that YAML reduces the amount of code needed in Python and also makes it more accessible for domain experts to work with different languages. The PyConAU mentor team who did a pre-review of the code made a note about this in their recommendations to JOSS. Do you have their recommendation letter?

@rbturnbull
Copy link

I've fixed the broken DOI now.

@editorialbot editorialbot added Track: 8 (MISC) Miscellaneous and removed Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Dec 7, 2024
@rbturnbull
Copy link

Hi @arfon - I hope you are going well. Have you had a chance to discuss this paper with the other editors regarding the size of the code base?

@arfon arfon removed the query-scope Submissions of uncertain scope for JOSS label Jan 18, 2025
@arfon
Copy link
Member

arfon commented Jan 18, 2025

@rbturnbull – sorry for the delay – yes, we're good to move forward, primarily because of the extensive work that has gone into the YAML content.

@arfon
Copy link
Member

arfon commented Jan 18, 2025

👋 @afrubin @claresloggett – I believe you both did the PyCon AU review, would you also be willing to complete a JOSS review here for this submission?

@rbturnbull
Copy link

@rbturnbull – sorry for the delay – yes, we're good to move forward, primarily because of the extensive work that has gone into the YAML content.

Thanks @arfon - that's great news

@rbturnbull
Copy link

👋 @afrubin @claresloggett – I believe you both did the PyCon AU review, would you also be willing to complete a JOSS review here for this submission?

I think @Wytamma was also involved in the PyCon AU review.

@afrubin
Copy link

afrubin commented Jan 19, 2025

👋 @afrubin @claresloggett – I believe you both did the PyCon AU review, would you also be willing to complete a JOSS review here for this submission?

I'm out of town currently, but very happy to take on this review when I get back in a little over a week.

@arfon
Copy link
Member

arfon commented Jan 20, 2025

I think @Wytamma was also involved in the PyCon AU review.

Would you also be willing to complete a JOSS review here for this submission?

@rbturnbull
Copy link

@arfon - I should have mentioned this in my earlier comment, but I have personal connection with @Wytamma. We have worked on some research projects together and co-authored articles.

@Wytamma
Copy link

Wytamma commented Jan 25, 2025

Thanks @rbturnbull I’d be happy to help out with the review if required and all good with @arfon

@arfon
Copy link
Member

arfon commented Jan 26, 2025

Ah, thanks for the heads up @rbturnbull. I'd rather avoid this conflict if we can.

@arfon
Copy link
Member

arfon commented Jan 26, 2025

@editorialbot add @afrubin as reviewer

@editorialbot
Copy link
Collaborator Author

@afrubin added to the reviewers list!

@arfon
Copy link
Member

arfon commented Jan 26, 2025

@jjmccollum @mikahama – 👋 would any of you be willing to review this submission for JOSS? The submission under consideration is Potnia: A Python library for the conversion of transliterated ancient texts to Unicode

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, and past papers in JOSS, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@claresloggett
Copy link

claresloggett commented Jan 27, 2025

Hi @arfon , I'm happy to review

@rbturnbull
Copy link

Hi @arfon - it is probably best for @jjmccollum not to review this paper because I am currently his PhD supervisor.

@arfon
Copy link
Member

arfon commented Jan 27, 2025

@editorialbot add @claresloggett as reviewer

@editorialbot
Copy link
Collaborator Author

@claresloggett added to the reviewers list!

@arfon
Copy link
Member

arfon commented Jan 27, 2025

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7725.

@arfon
Copy link
Member

arfon commented Jan 27, 2025

@afrubin, @claresloggett, @rbturnbull, @etour-unimelb – see you over in #7725 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants