-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Potnia: A Python library for the conversion of transliterated ancient texts to Unicode #7450
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@editorialbot assign me as editor 👋 @samhforbes – I'll take this paper as it's a PyCon AU submission. |
Assigned! @arfon is now the editor |
|
@etour-unimelb – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week. |
@editorialbot query scope |
Submission flagged for editorial review. |
Five most similar historical JOSS papers: UralicNLP: An NLP Library for Uralic Languages Inscriptis - A Python-based HTML to text conversion library optimized for knowledge extraction from the Web teiphy: A Python Package for Converting TEI XML Collations to NEXUS and Other Formats Crowsetta: A Python tool to work with any format for annotating animal vocalizations and bioacoustics data. Phonemizer: Text to Phones Transcription for Multiple Languages in Python |
Dear @arfon - thanks for the message. Sorry we didn't respond until now. Yes, the code only has about 425 lines of Python code (in the main package plus tests). But a lot of the work in the project is in the YAML files which tell the package how to run and this is more than 2000 lines of code. We designed it so that YAML reduces the amount of code needed in Python and also makes it more accessible for domain experts to work with different languages. The PyConAU mentor team who did a pre-review of the code made a note about this in their recommendations to JOSS. Do you have their recommendation letter? |
I've fixed the broken DOI now. |
Hi @arfon - I hope you are going well. Have you had a chance to discuss this paper with the other editors regarding the size of the code base? |
@rbturnbull – sorry for the delay – yes, we're good to move forward, primarily because of the extensive work that has gone into the YAML content. |
👋 @afrubin @claresloggett – I believe you both did the PyCon AU review, would you also be willing to complete a JOSS review here for this submission? |
Thanks @arfon - that's great news |
I think @Wytamma was also involved in the PyCon AU review. |
I'm out of town currently, but very happy to take on this review when I get back in a little over a week. |
Would you also be willing to complete a JOSS review here for this submission? |
Thanks @rbturnbull I’d be happy to help out with the review if required and all good with @arfon |
Ah, thanks for the heads up @rbturnbull. I'd rather avoid this conflict if we can. |
@editorialbot add @afrubin as reviewer |
@afrubin added to the reviewers list! |
@jjmccollum @mikahama – 👋 would any of you be willing to review this submission for JOSS? The submission under consideration is Potnia: A Python library for the conversion of transliterated ancient texts to Unicode The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Based on your experience, and past papers in JOSS, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out! Many thanks |
Hi @arfon , I'm happy to review |
Hi @arfon - it is probably best for @jjmccollum not to review this paper because I am currently his PhD supervisor. |
@editorialbot add @claresloggett as reviewer |
@claresloggett added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #7725. |
@afrubin, @claresloggett, @rbturnbull, @etour-unimelb – see you over in #7725 where the actual review will take place. |
Submitting author: @etour-unimelb (Emily Tour)
Repository: https://github.com/AncientNLP/potnia.git
Branch with paper.md (empty if default branch): main
Version: v0.3.0
Editor: @arfon
Reviewers: @afrubin, @claresloggett
Managing EiC: Arfon Smith
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @etour-unimelb. Currently, there isn't a JOSS editor assigned to your paper.
@etour-unimelb if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: