-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: target-methylseq-qc: a lightweight pipeline for collecting metrics from targeted sequence mapping files. #7238
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Five most similar historical JOSS papers: Acanthophis: a comprehensive plant hologenomics pipeline MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline CheckQC: Quick quality control of Illumina sequencing runs Koverage: Read-coverage analysis for massive (meta)genomics datasets |
@abhi18av Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:
|
@editorialbot invite @csoneson as editor |
Invitation to edit this submission sent! |
In principle I'm happy to edit this, but would like to first wait for the author's responses to @Kevin-Mattheus-Moerman's queries above. |
Dear @Kevin-Mattheus-Moerman and @csoneson , thank you for your time to evaluate this manuscript! I have addressed the comments inline.
Sure, I have updated the DOI for a few more citations, however as some entries don't have an associated publication (such as If there's a better way or a JOSS convention to address this, please let us know and we will be happy to accommodate.
Ah yes, there are a bunch of Github actions in the repo which are triggered upon relevant events. In addition, I have added an explanation in the REAMDE for the bundled test dataset which we provide to users for quick testing https://github.com/wal-yan/target-methylseq-qc?tab=readme-ov-file#testing .
In terms of the The principle changes regarding the implementation logic are of course in the Nextflow/Groovy layer, however as Nextflow is just the DSL for the orchestration of tasks, we have worked on other layers/languages as well. The samplesheet check (written in Python) is specific to this pipeline and checks for the overall validity of the samplesheet as a Furthermore, once the analysis is done, the generated results are merged and pushed to Finally in terms of the UI for Nextflow Schema renderers, the JSON format has been customized to reflect the principal parameters of the pipeline corresponding to different modes. I must also highlight that the creation of Therefore, kindly take this into consideration 🙏 EDIT (24-09-2024)Actually, I have realized that programs like Therefore none of the Nextflow (or config) files from the core implementation shows up |
@editorialbot check references |
@editorialbot generate pdf |
|
Five most similar historical JOSS papers: Acanthophis: a comprehensive plant hologenomics pipeline MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline CheckQC: Quick quality control of Illumina sequencing runs RNAsik: A Pipeline for complete and reproducible RNA-seq analysis that runs anywhere with speed and ease |
@editorialbot query scope |
Submission flagged for editorial review. |
@abhi18av thanks for providing those additional details. I have just flagged this submission for a scope review by our editorial board. This is because I need some help to determine if this work is in scope, and if the pipeline/workflow you present meets our substantial scholarly effort criterion. The scope review should take about 2 weeks to complete. |
I was trying to understand |
@abhi18av yes I'm aware cloc doesn't count nextflow code lines. Hence I asked you to elaborate. If you can help count/estimate these lines yourself that would be helpful. |
Hi @Kevin-Mattheus-Moerman , apologies for the late response. Sure, I am happy to provide the line counts for the Nextflow The total number of lines for Nextflow specific code is 1381. Tools used
Here's my method to compute nextflow code lines
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Five most similar historical JOSS papers: Acanthophis: a comprehensive plant hologenomics pipeline MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline CheckQC: Quick quality control of Illumina sequencing runs Koverage: Read-coverage analysis for massive (meta)genomics datasets |
Hi @csoneson, just to confirm something regarding the above message, do we need to propose some reviewers ourselves or this is already in progress? |
@abhi18av - apologies, it's been a busy week and I didn't get to this yet. You can suggest reviewers if you'd like, but it's not a requirement. I hope to start reaching out to potential reviewers very soon. |
No worries @csoneson , just wanted to confirm if that we are not blocking the process as per the requirement. We are happy to follow your lead, thank you! |
👋🏻 @Juke34, @rcannood, @ZeyuanSong - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?
More information about the review process can be found here. Thanks in advance! |
Would love to but I'm swamped at the moment. |
@rcannood No worries, thanks for your quick response! |
Swamped too, and already involved in a review process for another journal. I doubt to find any time before next year. |
@Juke34 No worries, thanks for letting me know! |
👋🏻 @sridhar0605, @beardymcjohnface, @lparsons, @telatin, @camillescott - would two of you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?
More information about the review process can be found here. Thanks in advance! |
Hello @csoneson, I'm interested, but considering the holiday break, this might take 3 to 4 weeks to be completed. Let me know if this can work for you :) |
Thanks @telatin - that sounds great. I will assign you now, and start the review issue once we have secured one more reviewer. |
@editorialbot add @telatin as reviewer |
@telatin added to the reviewers list! |
👋🏻 @sridhar0605, @beardymcjohnface, @lparsons, @camillescott - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?
More information about the review process can be found here. Thanks in advance! |
👋🏻 @daissi, @kdm9, @johandahlberg - would one of you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?
More information about the review process can be found here. Thanks in advance! |
@csoneson thank you for asking. I am unable to take this on at this time. |
@csoneson happy to review this. Please expect some delays in responses. |
I would be happy to review, however will be away from the keyboard until mid February 2025, which I assume is too late. |
@sridhar0605, @kdm9 - thank you for your responses! @sridhar0605 - I will assign you and open the review issue. |
@editorialbot add @sridhar0605 as reviewer |
@sridhar0605 added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #7608. |
Submitting author: @abhi18av (Abhinav Sharma)
Repository: https://github.com/wal-yan/target-methylseq-qc
Branch with paper.md (empty if default branch): master
Version: v2.0.0
Editor: @csoneson
Reviewers: @telatin, @sridhar0605
Managing EiC: Kevin M. Moerman
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @abhi18av. Currently, there isn't a JOSS editor assigned to your paper.
@abhi18av if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: