Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty buttton in the Data Quality KP (after save XP) #11143

Open
teolemon opened this issue Dec 18, 2024 · 1 comment
Open

Empty buttton in the Data Quality KP (after save XP) #11143

teolemon opened this issue Dec 18, 2024 · 1 comment

Comments

@teolemon
Copy link
Member

What

Empty buttton in the Data Quality KP (after save XP)

Image

@benbenben2
Copy link
Collaborator

< en: Categories warnings
en: Detected category from brand - Cigarettes
description:en: Those are likely to be cigarettes, based on the brand. There might be some false positives. All cigarettes should be categorized as non-food products, and moved to Open Products Facts by inputting OPF in the barcode field at the top of the edit page.
fix_action:en: move_to_opf
show_to:en: moderators

[...]

< en: Categories warnings
en: Detected category from brand - Pet Foods
description:en: Those are likely to be product for Open Pet Food Facts, based on the brand. There might be some false positives. All Pet Food products should be moved to Open Pet Food Facts by inputting OPFF in the barcode field at the top of the edit page.
fix_action:en: move_to_opff
show_to:en: moderators

< en: Categories warnings
en: Detected category from brand - Beauty
description:en: Those are likely to be product for Open Beauty Facts, based on the brand. There might be some false positives. All Beauty products should be moved to Open Beauty Facts by inputting OBF in the barcode field at the top of the edit page.
fix_action:en: move_to_obf
show_to:en: moderators

these 3 fix_actions are not defined in ProductOpener

I would suggest to NOT modify the hashmap %actions_urls BUT instead to replace "fix_action:en: move_to_" to "fix_action:en: add_categories" because there is a parallel PR to automatically move product.
+ need to update description to suggest contributors to add the category.

On top of that "show_to:en: moderators" might not be needed anymore if products can be move as I just described.
On the other hand, this tag was created only for these 3 entries in the taxonomy. So, in theory, we could update the function to not use it anymore. To have clean code: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/lib/ProductOpener/KnowledgePanelsContribution.pm. But it might be more complex...
@alexgarel did you work on this before? What do you think would be the best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To discuss and validate
Development

No branches or pull requests

2 participants