Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price deletion should also trigger associated price_tag status update #636

Closed
TTalex opened this issue Dec 19, 2024 · 1 comment · Fixed by #684
Closed

Price deletion should also trigger associated price_tag status update #636

TTalex opened this issue Dec 19, 2024 · 1 comment · Fixed by #684

Comments

@TTalex
Copy link
Collaborator

TTalex commented Dec 19, 2024

What

  • When a price is linked to a price_tag, removing said price (using API) clears the price_tag price_id but does not reset the price_tag status
  • This leads to a price_tag with status set to 1 ("price is already linked for this price tag"), but no valid price_id

Expected

  • status should be set to null, since "only price_tags with null status will be suggested in a "Hunger Games-like" games"

Part of

@raphodn
Copy link
Member

raphodn commented Jan 19, 2025

Ok fixed in #684 !
Indeed it was frustrating sometimes when using the Contribution Assistant.

I deployed, and did the cleanup ✅

// count
PriceTag.objects.filter(status=1, price_id=None).count()
// 60

// update
PriceTag.objects.filter(status=1, price_id=None).update(status=None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants