Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFF daily product (OPF) sync didn't happen #551

Open
serpico opened this issue Nov 7, 2024 · 5 comments
Open

OFF daily product (OPF) sync didn't happen #551

serpico opened this issue Nov 7, 2024 · 5 comments

Comments

@serpico
Copy link

serpico commented Nov 7, 2024

What

See, for example 3450971461701 :

@raphodn
Copy link
Member

raphodn commented Nov 7, 2024

I'm not 100% sure how the sync exactly works in terms of timestamps, there are a couple of parameters involved :

  • when the product was last modified in OFF
  • when the OFF product dump happens
  • when the OP product sync happens (daily at 15:30 server time)

Let's wait one more day :)

@raphodn
Copy link
Member

raphodn commented Nov 7, 2024

This sync is temporary.
The v2 is to sync with the live changes (openfoodfacts-events ?).
The v3 is to plug directly to the OFF database ^^

@raphodn
Copy link
Member

raphodn commented Nov 8, 2024

hmm wait @serpico I see on OFF that you updated the quantity on the 6/11, and it's correctly reflected in OP. Don't know when exactly the sync happened. And indeed the product's updated field was not updated...

@raphodn
Copy link
Member

raphodn commented Nov 9, 2024

I dug into the code, and realized we store this info in another field (not returned by the API)

'source_last_synced': datetime.datetime(2024, 11, 7, 16, 59, 52, 884000, tzinfo=datetime.timezone.utc)

Two options here :

  • return source_last_synced in the API
  • update the updated field (I think I didn't want to do it here to separate syncs and actual changes, though there's no actual product change in OP... even the price_count increment does not update this field...)

@raphodn raphodn changed the title OFF daily product sync didn't happen OFF daily product (OPF) sync didn't happen Dec 21, 2024
@raphodn
Copy link
Member

raphodn commented Dec 21, 2024

Linked, created an issue in the OFF server: openfoodfacts/openfoodfacts-server#11118 10 days ago. regarding not-up-to-date datadumps. fixed 5 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants