Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price addition: display current number of prices already inputted #1071

Closed
serpico opened this issue Dec 1, 2024 · 3 comments · Fixed by #1074, #1076 or #1075
Closed

Price addition: display current number of prices already inputted #1071

serpico opened this issue Dec 1, 2024 · 3 comments · Fixed by #1074, #1076 or #1075

Comments

@serpico
Copy link

serpico commented Dec 1, 2024

Problem

Since we now ask the total number of products on the receipt as well as the total amount/price it could be nice to have the number of prices already inputted displayed and updated for the user to compare keep track of...

Proposed solution

Maybe "slide" this value under the last product inputted and above Nouveau prix ( see screenshot ) ...Although it's a bit far from the above mentioned value of the total number of products on the receipt currently displayed a the bottom left of the page, as a chip, but it's where the line of sight of the user would be, where the last user operation is updated, IMHO

Image

@raphodn
Copy link
Member

raphodn commented Dec 1, 2024

Kinda linked : I did a PR today - #1072 - that scrolls to the "New price" form. On mobile, the count is pretty much never visible in the end, you have to scroll above to see it. It could be an expansion panel with just the count visible, but having a confirmation that the last price has effectively been added seems somthing to keep.

So it could be put in the footer of that "already added" card. Both the current "X prices already uploaded" and an extra "X prices already uploaded (of Y)" if that info is indeed specified.

There will be corner cases (un-managed) where the receipt price count is not exactly the expected number of prices to input : in the case of receipts that list duplicate products instead of having a count column (example here)

@raphodn raphodn changed the title Small UI tweak - display current number of prices already inputted Price addition: display current number of prices already inputted Dec 2, 2024
@raphodn raphodn added the UI label Dec 2, 2024
@raphodn
Copy link
Member

raphodn commented Dec 3, 2024

@serpico let me know once you test it :)

Image

@serpico
Copy link
Author

serpico commented Dec 3, 2024

@raphodn it looks good !!! no complaint :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment