From f81dfb32743fe54ccc342ebee7f528375f115ee4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Odini?= <raphodn@users.noreply.github.com>
Date: Tue, 25 Jun 2024 16:49:11 +0200
Subject: [PATCH] refactor(price card): rename components for clarification
 (#664)

---
 src/components/PriceFooterRow.vue                   | 8 ++++----
 src/components/ProofCard.vue                        | 2 +-
 src/components/{PriceProof.vue => ProofChip.vue}    | 2 +-
 src/components/{PriceOwnerChip.vue => UserChip.vue} | 8 ++++----
 src/i18n/locales/en.json                            | 1 +
 src/views/AddPriceSingle.vue                        | 2 +-
 6 files changed, 12 insertions(+), 11 deletions(-)
 rename src/components/{PriceProof.vue => ProofChip.vue} (95%)
 rename src/components/{PriceOwnerChip.vue => UserChip.vue} (76%)

diff --git a/src/components/PriceFooterRow.vue b/src/components/PriceFooterRow.vue
index 49d6643b401..97cb1feefcf 100644
--- a/src/components/PriceFooterRow.vue
+++ b/src/components/PriceFooterRow.vue
@@ -2,9 +2,9 @@
   <v-row style="margin-top:0;">
     <v-col :cols="userIsPriceOwner ? '11' : '12'">
       <LocationChip v-if="!hidePriceLocation" class="mr-1" :location="price.location" :locationId="price.location_id" :readonly="readonly" />
-      <PriceOwnerChip class="mr-1" :price="price" :readonly="readonly" />
+      <UserChip class="mr-1" :username="price.owner" :readonly="readonly" />
       <RelativeDateTimeChip class="mr-1" :dateTime="price.created" />
-      <PriceProof v-if="price.proof && !hidePriceProof" :proof="price.proof" />
+      <ProofChip v-if="price.proof && !hidePriceProof" :proof="price.proof" />
     </v-col>
   </v-row>
 
@@ -19,9 +19,9 @@ import { useAppStore } from '../store'
 export default {
   components: {
     LocationChip: defineAsyncComponent(() => import('../components/LocationChip.vue')),
-    PriceOwnerChip: defineAsyncComponent(() => import('../components/PriceOwnerChip.vue')),
+    UserChip: defineAsyncComponent(() => import('../components/UserChip.vue')),
     RelativeDateTimeChip: defineAsyncComponent(() => import('../components/RelativeDateTimeChip.vue')),
-    PriceProof: defineAsyncComponent(() => import('../components/PriceProof.vue')),
+    ProofChip: defineAsyncComponent(() => import('../components/ProofChip.vue')),
     PriceActionMenuButton: defineAsyncComponent(() => import('../components/PriceActionMenuButton.vue')),
   },
   props: {
diff --git a/src/components/ProofCard.vue b/src/components/ProofCard.vue
index 1a8615f6662..51718a85ad3 100644
--- a/src/components/ProofCard.vue
+++ b/src/components/ProofCard.vue
@@ -1,7 +1,7 @@
 <template>
   <v-card :id="'proof_' + proof.id" @click="selectProof">
     <v-card-title v-if="!hideProofHeader">
-      {{ $t('ProofCard.Proof') }} <v-btn style="float:right;" variant="text" density="compact" icon="mdi-close" @click="close" />
+      {{ $t('Common.Proof') }} <v-btn style="float:right;" variant="text" density="compact" icon="mdi-close" @click="close" />
     </v-card-title>
 
     <v-divider v-if="!hideProofHeader" />
diff --git a/src/components/PriceProof.vue b/src/components/ProofChip.vue
similarity index 95%
rename from src/components/PriceProof.vue
rename to src/components/ProofChip.vue
index 583a55c4b5d..d44cafb2abd 100644
--- a/src/components/PriceProof.vue
+++ b/src/components/ProofChip.vue
@@ -4,7 +4,7 @@
     label
     size="small"
     density="comfortable"
-    :title="$t('PriceCard.Proof')"
+    :title="$t('Common.Proof')"
     @click="openDialog"
   >
     <v-icon icon="mdi-image" />
diff --git a/src/components/PriceOwnerChip.vue b/src/components/UserChip.vue
similarity index 76%
rename from src/components/PriceOwnerChip.vue
rename to src/components/UserChip.vue
index 2b48f669706..b48b6d91e14 100644
--- a/src/components/PriceOwnerChip.vue
+++ b/src/components/UserChip.vue
@@ -1,15 +1,15 @@
 <template>
   <v-chip label size="small" density="comfortable" @click="goToUser()">
     <v-icon start icon="mdi-account" />
-    {{ price.owner }}
+    {{ username }}
   </v-chip>
 </template>
 
 <script>
 export default {
   props: {
-    price: {
-      type: Object,
+    username: {
+      type: String,
       default: null
     },
     readonly: {
@@ -22,7 +22,7 @@ export default {
       if (this.readonly) {
         return
       }
-      this.$router.push({ path: `/users/${this.price.owner}` })
+      this.$router.push({ path: `/users/${this.username}` })
     },
   }
 }
diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
index 8cc606a3e47..9e9e395e7eb 100644
--- a/src/i18n/locales/en.json
+++ b/src/i18n/locales/en.json
@@ -110,6 +110,7 @@
 		"AddPrice": "Add a price",
 		"AddToOFF": "Add to {name}",
 		"Brand": "Brand",
+		"Proof": "Proof",
 		"Country": "Country",
 		"Currency": "Currency",
 		"CurrencyMissing": "Currency missing",
diff --git a/src/views/AddPriceSingle.vue b/src/views/AddPriceSingle.vue
index f0700c3a500..c4cbe6292d8 100644
--- a/src/views/AddPriceSingle.vue
+++ b/src/views/AddPriceSingle.vue
@@ -66,7 +66,7 @@
             </h3>
             <PriceInputRow :priceForm="addPriceSingleForm" :hideCurrencyChoice="true" @filled="pricePriceFormFilled = $event" />
             <h3 class="mt-4 mb-1">
-              {{ $t('AddPriceSingle.PriceDetails.Proof') }}
+              {{ $t('Common.Proof') }}
             </h3>
           </v-card-text>
         </v-card>