Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Remove HomePageCourses API v1 #287

Open
2 tasks
BryanttV opened this issue Jan 28, 2025 · 3 comments
Open
2 tasks

[DEPR]: Remove HomePageCourses API v1 #287

BryanttV opened this issue Jan 28, 2025 · 3 comments
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@BryanttV
Copy link

BryanttV commented Jan 28, 2025

Proposal Date

2025-01-28

Target Ticket Acceptance Date

2025-02-11

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

The HomePageCourses API v1 will be replaced by v2, which offers improvements including pagination, filtering, and sorting. As of Sumac, v2 is the default API used to query the course listing from Studio.

Removal

To completely remove the API v1 in edx-platform it’s necessary:

Also, it's necessary to remove all references to API v1 in the Authoring MFE. This work is in progress:

Replacement

API v2 completely replaces API v1. The PRs related to functionality are as follows:

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

  • Remove API v1 from edx-platform
  • Remove API v1 references from frontend-app-authoring (WIP)
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Jan 28, 2025
@BryanttV
Copy link
Author

Hi @mariajgrimaldi @feanil @bradenmacdonald. Could you check this proposal?

@bradenmacdonald
Copy link

Removing v1 from the authoring MFE ASAP makes sense. On the platform side, I'm just wondering if we need to mark it as deprecated in Teak and then remove it in the next release, to give API consumers more time to adjust.

@BryanttV
Copy link
Author

Thanks for your comment @bradenmacdonald. Yeah, I think it's better to mark the code as deprecated for Teak, and finally, in Ulmo remove it. I can update the proposal, what do you think? @mariajgrimaldi @feanil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Proposed
Development

No branches or pull requests

3 participants