From d1663ceb3f532b4616a4de11324c86e8a90d2517 Mon Sep 17 00:00:00 2001 From: Kyrylo Hudym-Levkovych Date: Thu, 16 Nov 2023 11:11:25 +0200 Subject: [PATCH 1/4] fix: add min-height to form.control textarea --- src/Form/_index.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Form/_index.scss b/src/Form/_index.scss index ef849089bd..31c3f6d80e 100644 --- a/src/Form/_index.scss +++ b/src/Form/_index.scss @@ -46,6 +46,10 @@ $select-icon-padding: .5625rem !default; flex-grow: 1; align-items: flex-start; + .form-control { + min-height: 2.75rem; + } + @media (min-width: map-get($grid-breakpoints, "sm")) { margin-inline-end: $custom-control-gutter; } From 4a63c2ddaf9aea98062f0ccb8d0b5eafd344fd85 Mon Sep 17 00:00:00 2001 From: Kyrylo Hudym-Levkovych Date: Tue, 21 Nov 2023 09:59:53 +0200 Subject: [PATCH 2/4] refactor: add changes after review --- src/Form/_index.scss | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/Form/_index.scss b/src/Form/_index.scss index 31c3f6d80e..6c67590f5c 100644 --- a/src/Form/_index.scss +++ b/src/Form/_index.scss @@ -46,8 +46,16 @@ $select-icon-padding: .5625rem !default; flex-grow: 1; align-items: flex-start; - .form-control { - min-height: 2.75rem; + .form-control { + min-height: $input-height; + } + + .form-control-lg { + min-height: $input-height-lg; + } + + .form-control-sm { + min-height: $input-height-sm; } @media (min-width: map-get($grid-breakpoints, "sm")) { From 5f9fcd143670977aa573f820d05ae60359ee362f Mon Sep 17 00:00:00 2001 From: Kyrylo Hudym-Levkovych Date: Tue, 21 Nov 2023 10:36:15 +0200 Subject: [PATCH 3/4] fix: fix linter problems --- src/Form/_index.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Form/_index.scss b/src/Form/_index.scss index 6c67590f5c..5332f2c0b9 100644 --- a/src/Form/_index.scss +++ b/src/Form/_index.scss @@ -46,14 +46,14 @@ $select-icon-padding: .5625rem !default; flex-grow: 1; align-items: flex-start; - .form-control { + .form-control { min-height: $input-height; } .form-control-lg { min-height: $input-height-lg; } - + .form-control-sm { min-height: $input-height-sm; } From 3e4615b0be7dc95bcb86d955cee9c1f1efec80a6 Mon Sep 17 00:00:00 2001 From: Kyrylo Hudym-Levkovych Date: Tue, 21 Nov 2023 13:46:07 +0200 Subject: [PATCH 4/4] refactor: apply styles only for textarea --- src/Form/_index.scss | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Form/_index.scss b/src/Form/_index.scss index 5332f2c0b9..6ce41363c4 100644 --- a/src/Form/_index.scss +++ b/src/Form/_index.scss @@ -46,16 +46,18 @@ $select-icon-padding: .5625rem !default; flex-grow: 1; align-items: flex-start; - .form-control { - min-height: $input-height; - } + textarea { + &.form-control { + min-height: $input-height; + } - .form-control-lg { - min-height: $input-height-lg; - } + &.form-control-lg { + min-height: $input-height-lg; + } - .form-control-sm { - min-height: $input-height-sm; + &.form-control-sm { + min-height: $input-height-sm; + } } @media (min-width: map-get($grid-breakpoints, "sm")) {