Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] chore: merging master into alpha #2729

Closed

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Oct 18, 2023

Description

  • sync alpha to master;
  • some refactoring.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

khudym and others added 13 commits October 12, 2023 16:26
* refactor: move enzyme to react testing library

* feat: rewriting tests from Enzyme to RTL

* refactor: update tests 2

* refactor: rewrite tests using react testing library

* refactor: rewrite test using react testing library 2part

* refactor: refactor after review part 1

* refactor: replace fireEvent with userEvent where it is possible

* fix: fix console errors

---------

Co-authored-by: monteri <lansevermore>
Co-authored-by: PKulkoRaccoonGang <[email protected]>
Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
…et (openedx#2705)

* fix: fixed duplicate calls in FormRadioSet and FormCheckboxSet

* refactor: added new tests

* refactor: refactoring after review
# Conflicts:
#	package-lock.json
#	package.json
#	src/Button/deprecated/Button.test.jsx
#	src/CheckBox/CheckBox.test.jsx
#	src/CheckBoxGroup/CheckBoxGroup.test.jsx
#	src/Dropdown/deprecated/Dropdown.test.jsx
#	src/Dropdown/deprecated/__snapshots__/Dropdown.test.jsx.snap
#	src/Fieldset/Fieldset.test.jsx
#	src/Fieldset/index.jsx
#	src/Input/input.test.jsx
#	src/InputText/InputText.test.jsx
#	src/ListBox/ListBox.test.jsx
#	src/ListBoxOption/ListBoxOption.test.jsx
#	src/Modal/index.jsx
#	src/RadioButtonGroup/RadioButtonGroup.test.jsx
#	src/SearchField/__snapshots__/SearchField.test.jsx.snap
#	src/StatusAlert/StatusAlert.test.jsx
#	src/Table/Table.test.jsx
#	src/Table/index.jsx
#	src/Tabs/deprecated/Tabs.test.jsx
#	src/ValidationFormGroup/ValidationFormGroup.test.jsx
#	src/ValidationFormGroup/__snapshots__/ValidationFormGroup.test.jsx.snap
#	src/ValidationFormGroup/index.jsx
@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ee5a1c
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6530295d9f581200083c8b3b
😎 Deploy Preview https://deploy-preview-2729--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 18, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/alpha-to-master branch from 7febffc to 6ee5a1c Compare October 18, 2023 18:52
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft October 18, 2023 19:16
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f465b40) 92.61% compared to head (6ee5a1c) 93.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #2729      +/-   ##
==========================================
+ Coverage   92.61%   93.28%   +0.67%     
==========================================
  Files         215      215              
  Lines        3629     3635       +6     
  Branches      895      898       +3     
==========================================
+ Hits         3361     3391      +30     
+ Misses        263      239      -24     
  Partials        5        5              
Files Coverage Δ
src/Annotation/index.jsx 100.00% <ø> (ø)
src/Breadcrumb/index.jsx 100.00% <ø> (ø)
src/Card/CardBody.jsx 100.00% <100.00%> (ø)
src/Card/CardDivider.jsx 100.00% <100.00%> (ø)
src/Card/CardStatus.jsx 100.00% <ø> (ø)
src/Chip/index.tsx 100.00% <ø> (ø)
src/ChipCarousel/index.tsx 84.84% <100.00%> (ø)
src/DataTable/BulkActions.jsx 100.00% <100.00%> (ø)
src/DataTable/CollapsibleButtonGroup.jsx 100.00% <ø> (ø)
src/DataTable/EmptyTable.jsx 100.00% <100.00%> (ø)
... and 28 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openedx-webhooks
Copy link

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants