-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] chore: merging master into alpha #2729
[BD-46] chore: merging master into alpha #2729
Conversation
* refactor: move enzyme to react testing library * feat: rewriting tests from Enzyme to RTL * refactor: update tests 2 * refactor: rewrite tests using react testing library * refactor: rewrite test using react testing library 2part * refactor: refactor after review part 1 * refactor: replace fireEvent with userEvent where it is possible * fix: fix console errors --------- Co-authored-by: monteri <lansevermore> Co-authored-by: PKulkoRaccoonGang <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
…et (openedx#2705) * fix: fixed duplicate calls in FormRadioSet and FormCheckboxSet * refactor: added new tests * refactor: refactoring after review
# Conflicts: # package-lock.json # package.json # src/Button/deprecated/Button.test.jsx # src/CheckBox/CheckBox.test.jsx # src/CheckBoxGroup/CheckBoxGroup.test.jsx # src/Dropdown/deprecated/Dropdown.test.jsx # src/Dropdown/deprecated/__snapshots__/Dropdown.test.jsx.snap # src/Fieldset/Fieldset.test.jsx # src/Fieldset/index.jsx # src/Input/input.test.jsx # src/InputText/InputText.test.jsx # src/ListBox/ListBox.test.jsx # src/ListBoxOption/ListBoxOption.test.jsx # src/Modal/index.jsx # src/RadioButtonGroup/RadioButtonGroup.test.jsx # src/SearchField/__snapshots__/SearchField.test.jsx.snap # src/StatusAlert/StatusAlert.test.jsx # src/Table/Table.test.jsx # src/Table/index.jsx # src/Tabs/deprecated/Tabs.test.jsx # src/ValidationFormGroup/ValidationFormGroup.test.jsx # src/ValidationFormGroup/__snapshots__/ValidationFormGroup.test.jsx.snap # src/ValidationFormGroup/index.jsx
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the pull request, @PKulkoRaccoonGang! This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
7febffc
to
6ee5a1c
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2729 +/- ##
==========================================
+ Coverage 92.61% 93.28% +0.67%
==========================================
Files 215 215
Lines 3629 3635 +6
Branches 895 898 +3
==========================================
+ Hits 3361 3391 +30
+ Misses 263 239 -24
Partials 5 5
☔ View full report in Codecov by Sentry. |
@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist