Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove learner_downloadable field in ComponentVersionContent #237

Closed
ormsbee opened this issue Oct 2, 2024 · 0 comments · Fixed by #256
Closed

Remove learner_downloadable field in ComponentVersionContent #237

ormsbee opened this issue Oct 2, 2024 · 0 comments · Fixed by #256
Assignees

Comments

@ormsbee
Copy link
Contributor

ormsbee commented Oct 2, 2024

I originally added the learner_downloadable flag to ComponentVersionContent with the thought that it would reduce the odds of sensitive assets being made publicly downloadable. But in practice, it's just been a source of unnecessary complexity, and we're more or less ignoring it in libraries code that calls into openedx-learning. Instead, we're using the convention that any path starting with static/ is meant to be downloadable–a convention that Learning Core can stay completely ignorant of.

This would involve removing the model field and all calls to it. However, public API functions could continue to accept the field, and log a warning message–that might make it easier to support minor fixes to Sumac over the next few weeks without branching.

@ormsbee ormsbee self-assigned this Oct 2, 2024
@ormsbee ormsbee moved this to In grooming in Libraries Overhaul Oct 25, 2024
@ormsbee ormsbee changed the title Remove learner_downloadable flag in ComponentVersionContent Remove learner_downloadable field in ComponentVersionContent Oct 25, 2024
@ormsbee ormsbee removed their assignment Nov 1, 2024
@Ian2012 Ian2012 self-assigned this Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Libraries Overhaul Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants