Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] The loading indicator overlaps “Shift due dates” button #419

Open
sergeymomot opened this issue Apr 30, 2024 · 5 comments
Open
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@sergeymomot
Copy link

Sometimes, if the Internet connection is slow, the loading indicator overlaps “Shift due dates” button: needs to open any course with “Shift due dates” button with a slow Internet connection. Can be repeated only on iPhone

f95394ce-d772-4d8b-8250-8df99aeb9912
@sergeymomot sergeymomot added the bug Report of or fix for something that isn't working as intended label Apr 30, 2024
@sergeymomot sergeymomot changed the title [iOS] The loading indicator overlaps the “Shift due dates” button [iOS] The loading indicator overlaps “Shift due dates” button Apr 30, 2024
@shafqat-muneer
Copy link
Contributor

@sdaitzman Do you have any design considerations for this issue? Multiple buttons, similar to those shown in the screenshot, could be included. This loading indicator operates at the application level and is displayed during processing or API call.

Simulator Screenshot - iPhone 15 - 2024-05-14 at 15 23 38

@sdaitzman
Copy link

Hey @shafqat-muneer, thanks for reaching out about this! I don't have any major design considerations for the loader aside from supporting moving its position so it does not overlap content.

When the "shift due dates" CTA is presented, I think the "Resume" CTA should be switched to a secondary style if possible so we only show the user one clear recommended next step, but still allow them to continue with content without shifting due dates if they prefer. I updated the Figma file to make sure that state is represented, and I'm attaching a screenshot here as well. This could fall under a separate ticket, just wanted to mention it since it relates to this view/state.

image

@moiz994
Copy link

moiz994 commented May 17, 2024

hey @sdaitzman, in the legacy apps we have implemented the Resume/Continue button to be secondary regardless of any other CTA on the screen because there are certain cases where other CTAs are presented on the screen such as the upgrade button or the shift due dates button.
Wouldn't it be a better approach to standardize the resume course button rather changing it based on certain cases? This might even add code complexity.

@sdaitzman
Copy link

Hi @moiz994, was running through old threads and realized I never replied here. I completely agree the CTA hierarchy on this screen is a bit messy right now between CTAs that were added from different teams, causing code complexity and usability issues. After the conference coming up, I'm hoping to spend some time documenting the current behavior and proposing a more consistent hierarchy for CTAs on the dashboard and course home.

Personally, I think it's worth promoting the course resume button to this primary status by default since it's the most likely action on this screen, and one we want to encourage. I'm open to trying out a variant with a secondary resume button.

@moiz994
Copy link

moiz994 commented Jun 20, 2024

Sure, that sounds good. Let's brainstorm after the conference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: No status
Development

No branches or pull requests

5 participants