Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] There are no subtitles for videos opened from the "Dates" Course section #316

Closed
sergeymomot opened this issue Mar 6, 2024 · 0 comments · Fixed by #340
Closed

[iOS] There are no subtitles for videos opened from the "Dates" Course section #316

sergeymomot opened this issue Mar 6, 2024 · 0 comments · Fixed by #340
Assignees
@forgotvas
Labels
bug Report of or fix for something that isn't working as intended

Comments

@sergeymomot
Copy link

sergeymomot commented Mar 6, 2024 •
edited
Loading

Open any available video from "Dates" course tab and then the same video from "Course" or "Videos" tab. Observe that there are no subtitles for videos opened from the "Dates" Course section.

29dd2613-8707-4bef-9ec0-b9cfaf1aef32

Subtitles for videos should always open from any section.
@sergeymomot sergeymomot added the bug Report of or fix for something that isn't working as intended label Mar 6, 2024
@forgotvas forgotvas moved this to In Development in Open edX Mobile Roadmap Mar 13, 2024
forgotvas added a commit to edx/edx-mobile-marketplace-ios that referenced this issue Mar 13, 2024
@forgotvas
fix: subtitles for dates tab
301821f 
[iOS] There are no subtitles for videos opened from the "Dates" Course section openedx#316
@forgotvas forgotvas mentioned this issue Mar 13, 2024
Merged
@forgotvas forgotvas linked a pull request Mar 13, 2024 that will close this issue
[iOS] There are no subtitles for videos opened from the "Dates" Course section #340
Merged
@forgotvas forgotvas moved this from In Development to In Code Review / Final Acceptance in Open edX Mobile Roadmap Mar 13, 2024
volodymyr-chekyrta pushed a commit that referenced this issue Mar 22, 2024
@forgotvas
[iOS] There are no subtitles for videos opened from the "Dates" Cours…
ea50fb1 
…e section (#340)

* fix: subtitles for dates tab

[iOS] There are no subtitles for videos opened from the "Dates" Course section #316

* fix: merge conflict
@forgotvas forgotvas moved this from In Code Review / Final Acceptance to Done in Open edX Mobile Roadmap Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forgotvas forgotvas

Labels
bug Report of or fix for something that isn't working as intended
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
2 participants
@forgotvas @sergeymomot