feat: Added login and register capability in discovery for pre login exploration #202
Conversation
saeedbashir
force-pushed
the
saeed/pre_login_exploration_discovery
branch
from
57529b6 to
b7ab020
Compare
Course/Course/Presentation/Details/CourseDetailsViewModel.swift
Outdated
Show resolved
Hide resolved
|
@saeedbashir please look on Tests - something was failed there. Thank you |
|
@saeedbashir I think needs to add @volodymyr-chekyrta as Reviewer also. Thank you |
I was waiting for an approval from our team. I have now requested a review from @volodymyr-chekyrta |
There was a problem hiding this comment.
@saeedbashir I encounter an error when I click on the View Course button on the course dashboard. Kindly investigate this issue.
Additionally, I have included some comments. Please review them as well.
| @@ -83,7 +89,7 @@ public struct StartupView: View { | |||
| } | |||
| .padding(.horizontal, isHorizontal ? 10 : 24) | |||
|
|
|||
| LogistrationBottomView(viewModel: viewModel) | |||
| LogistrationBottomView(viewModel: viewModel, sourceScreen: .startup) | |||
There was a problem hiding this comment.
In various locations, we utilize LogistrationSourceScreen.startup, while here it employs .startup. It is necessary to ensure uniformity.
miankhalid
changed the title
saeedbashir
dismissed stale reviews from eyatsenkoperpetio, rnr, and shafqat-muneer
via
89d5559
|
@volodymyr-chekyrta It's ready for another pass. |
|
No other requests from my side; we can address current feedback and merge. |
@volodymyr-chekyrta Merge is disabled for me; I guess it will get enabled after your approval. |
Here is some miscommunication. |
Oh my bad, I'd already made those changes but forgot to push them. Just pushed. |
Thank you! I resolved threads about code formatting. Could you please check the threads about the We have to decouple modules 🙏; we can merge after that. Thank you! |
@volodymyr-chekyrta Done |
|
@volodymyr-chekyrta I guess every comment is addressed now. I'm not sure why, but somehow the complete review was missed. |
|
@saeedbashir Thank you! |
…exploration (openedx#202) * feat: added login and register capebility in discovery for pre login exploration * refactor: address review feedback * fix: fix broken tests * fix: linking authorization framework with discovery framework * refactor: address review feedback * refactor: address review feedback * fix: fix broken tests after changes * refactor: address review feedback * refactor: changing LogistrationBottomView style from model to closure and moving it to Core * refactor: address review feedback * refactor: decouple Authorization and Discovery module, remove unused imports * refactor: removing unused imports
…exploration (openedx#202) * feat: added login and register capebility in discovery for pre login exploration * refactor: address review feedback * fix: fix broken tests * fix: linking authorization framework with discovery framework * refactor: address review feedback * refactor: address review feedback * fix: fix broken tests after changes * refactor: address review feedback * refactor: changing LogistrationBottomView style from model to closure and moving it to Core * refactor: address review feedback * refactor: decouple Authorization and Discovery module, remove unused imports * refactor: removing unused imports
This PR adds the functionality of sign-in and register in the discovery and discovery course detail page when the discovery accessed from the startup screen (pre-login exploration). The pre-login experience is being controlled with the feature flag
PRE_LOGIN_EXPERIENCE_ENABLEDHere is the screen recording of the feature:
Screen.Recording.2023-12-13.at.11.26.59.AM.mov