Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Move Sequence Units level to Course home view as nested list #155

Closed
Tracked by #111
sergeymomot opened this issue Nov 8, 2023 · 9 comments · Fixed by #192
Closed
Tracked by #111

[iOS] Move Sequence Units level to Course home view as nested list #155

sergeymomot opened this issue Nov 8, 2023 · 9 comments · Fixed by #192
Assignees

Comments

@sergeymomot
Copy link

sergeymomot commented Nov 8, 2023

Right now Course Sequence units are opens on separate page:
or281520642-3ca96add-aa5f-4319-b8f0-2ecd821f9f5e

we need to get rid of this separate page and move Sequence units to Course home view as nested list:
281520985-8804e966-432c-4575-8175-e85d28846e2a

so that Sequence units list appears/disappears as nested list when user tap on Course Sequence name:
281521737-0ffb5292-ddc5-4b49-9b94-af5943394005

@sergeymomot sergeymomot moved this to In Development in Open edX Mobile Roadmap Nov 8, 2023
@sergeymomot sergeymomot changed the title Move Course Sequence to Course Chapter level [iOS] Move Sequence Units level to Course home view as nested list [iOS] Nov 8, 2023
@nizmaylova nizmaylova changed the title Move Sequence Units level to Course home view as nested list [iOS] [iOS] Move Sequence Units level to Course home view as nested list Nov 16, 2023
@marcotuts
Copy link

Hi! - this is not the expected future direction, the ticket should not be completed as defined. FYI @sergeymomot

@marcotuts
Copy link

@sdaitzman - fyi on another area of design definition

@touchapp
Copy link

hey @marcotuts sorry confused by this. Didn't we discuss and agree on this direction? Did something change?

@marcotuts
Copy link

No we didn't discuss this before, not sure what other item other than the resume course button logic being cleaned up we discussed before.

Adding a third tier of hierarchy to the course outline page I don't remember ever discussing or seeing proposed before

@moiz994
Copy link

moiz994 commented Dec 5, 2023

@touchapp this was mentioned in yesterday's meeting so I was reviewing it and I see that the implementation logic is a little off as compared to the prod edX app. The dropdown/accordion should be on the section level of the course but in this implementation, it is on the sub-section level.

I think that's what @marcotuts means by:

Adding a third tier of hierarchy to the course outline page I don't remember ever discussing or seeing proposed before

Below are some screenshots that can help in spotting the difference.

Prod App Current Work
Screenshot 2023-12-05 at 11 24 35 AM

@touchapp
Copy link

touchapp commented Dec 7, 2023

Hey @moiz994 we don't have a requirement to directly copy the prod edx app. What we are doing is adding functionality that exists on the prod app. They won't look exactly the same.

@moiz994
Copy link

moiz994 commented Dec 7, 2023

It's not about the looks but the implemented functionality is not matching the functionality. We've added three levels of course hierarchy on this page but it should be just the first two. Check out where the accordion sits in both images.

@touchapp
Copy link

touchapp commented Dec 7, 2023

@moiz994 yes, you're right. I discussed this with Eugene and Poornima. The functionality will be updated. Thanks for the call-out.

cc @eyatsenkoperpetio

@marcotuts
Copy link

I don't know the exact goals on the edX side for this navigation, but this change is not one I would recommend merging into the experience - our goal with navigation updates is to remove navigational complexity and we believe we will have a path to eliminate the section unit listing page (as described in the issue above) but the solution we have in mind does not add this content to the course home page / outline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants