-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Move Sequence Units level to Course home view as nested list #155
Comments
Hi! - this is not the expected future direction, the ticket should not be completed as defined. FYI @sergeymomot |
@sdaitzman - fyi on another area of design definition |
hey @marcotuts sorry confused by this. Didn't we discuss and agree on this direction? Did something change? |
No we didn't discuss this before, not sure what other item other than the resume course button logic being cleaned up we discussed before. Adding a third tier of hierarchy to the course outline page I don't remember ever discussing or seeing proposed before |
@touchapp this was mentioned in yesterday's meeting so I was reviewing it and I see that the implementation logic is a little off as compared to the prod edX app. The dropdown/accordion should be on the section level of the course but in this implementation, it is on the sub-section level. I think that's what @marcotuts means by:
Below are some screenshots that can help in spotting the difference.
|
Hey @moiz994 we don't have a requirement to directly copy the prod edx app. What we are doing is adding functionality that exists on the prod app. They won't look exactly the same. |
It's not about the looks but the implemented functionality is not matching the functionality. We've added three levels of course hierarchy on this page but it should be just the first two. Check out where the accordion sits in both images. |
@moiz994 yes, you're right. I discussed this with Eugene and Poornima. The functionality will be updated. Thanks for the call-out. |
I don't know the exact goals on the edX side for this navigation, but this change is not one I would recommend merging into the experience - our goal with navigation updates is to remove navigational complexity and we believe we will have a path to eliminate the section unit listing page (as described in the issue above) but the solution we have in mind does not add this content to the course home page / outline. |
Right now Course Sequence units are opens on separate page:
we need to get rid of this separate page and move Sequence units to Course home view as nested list:
so that Sequence units list appears/disappears as nested list when user tap on Course Sequence name:
The text was updated successfully, but these errors were encountered: