Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mashal m/replace edx/paragon frontend build #296

Closed
wants to merge 10 commits into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Dec 29, 2023

Part of openedx/axim-engineering#23

This replaces the @edx/paragon and @edx/frontend-build package.
Imports have been updated to use the same locations in the new package.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (5389058) to head (fbab4b2).

Current head fbab4b2 differs from pull request most recent head 19113e1

Please upload reports for the commit 19113e1 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files          43       43           
  Lines         783      783           
  Branches      154      154           
=======================================
  Hits          533      533           
  Misses        242      242           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review February 12, 2024 11:29
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 23, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Mashal-m! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@BilalQamar95
Copy link
Contributor

Closing this PR since these upgrades were merged with #299 & this PR is no longer required

@openedx-webhooks
Copy link

@Mashal-m Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants