Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library component sidebar preview messes up aspect ratio of images #1465

Closed
bradenmacdonald opened this issue Nov 4, 2024 · 5 comments
Closed

Library component sidebar preview messes up aspect ratio of images #1465

bradenmacdonald opened this issue Nov 4, 2024 · 5 comments
Assignees
@rpenido
Labels
bug Report of or fix for something that isn't working as intended

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 4, 2024 •
edited
Loading

When an image is included in a Text component with an explicit width and height, like TinyMCE does by default:

<img src="http://studio.local.openedx.io:8001/library_assets/component_versions/f12c83a3-2aab-4599-a145-eab778cc62a4/static/XBlock%20Distribution.png" alt="Example" width="1294" height="837" />

Then when it appears in the preview, it will have the specified height but the wrong width, resulting in a distorted aspect ratio:

Screenshot 2024-11-06 at 12 01 40 PM
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Nov 4, 2024
@bradenmacdonald bradenmacdonald moved this to In grooming in Libraries Overhaul Nov 4, 2024
@rpenido
Copy link
Contributor

rpenido commented Nov 5, 2024

I failed to reproduce this using the Text component.
image

@bradenmacdonald
Copy link
Contributor Author

@kdmccormick @rpenido I figured out how this happens and updated the description.

@rpenido rpenido mentioned this issue Nov 6, 2024
Merged
@rpenido rpenido self-assigned this Nov 6, 2024
@rpenido rpenido moved this from In grooming to In Progress in Libraries Overhaul Nov 6, 2024
@rpenido rpenido mentioned this issue Nov 6, 2024
Merged
@navinkarkera navinkarkera moved this from In Progress to Ready for AC testing in Libraries Overhaul Nov 9, 2024
@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Friendly reminder that this is ready for AC testing on the sandbox

@bradenmacdonald
Copy link
Contributor Author

I reported the original bug and can confirm it is now fixed on the sandbox.

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpenido rpenido

Labels
bug Report of or fix for something that isn't working as intended
Projects
Libraries Overhaul
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rpenido @bradenmacdonald @navinkarkera @ChrisChV