Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library content blocks display in units with new Library icons #1338

Closed
Tracked by #1095
jmakowski1123 opened this issue Sep 26, 2024 · 5 comments
Closed
Tracked by #1095

Library content blocks display in units with new Library icons #1338

jmakowski1123 opened this issue Sep 26, 2024 · 5 comments

Comments

@jmakowski1123
Copy link

Components on a unit page that are sourced from a Library display with this icon:

Image

The icon is static and not clickable. Its purpose is to communicate to authors that this content has been sourced from a Library.

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 It's not stated here but I'm guessing this should be implemented in both the legacy and MFE Unit page?

@jmakowski1123
Copy link
Author

Yes, the MFE unit page will not be done by Sumac, so I'd prioritize the legacy page for now and we can circle back and implement it on the new MFE page for Teak.

@bradenmacdonald
Copy link
Contributor

I have a draft version of this ready for the legacy page: kdmccormick/edx-platform#16

@jmakowski1123
Copy link
Author

I have a draft version of this ready for the legacy page: kdmccormick/edx-platform#16

@bradenmacdonald Where can I go to test this?

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 Kyle will merge his PR tomorrow and then after we update the sandbox you'll be able to see it.

@jmakowski1123 jmakowski1123 moved this from Backlog to Done in Libraries Overhaul Oct 30, 2024
@jmakowski1123 jmakowski1123 closed this as completed by moving to Done in Libraries Overhaul Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants