From b7241a124c110b318d4422813ab5c041d8c71d14 Mon Sep 17 00:00:00 2001 From: Braden MacDonald Date: Wed, 29 Jan 2025 09:20:48 -0800 Subject: [PATCH] docs: clarify/update a TODO comment about Meilisearch functionality (#1638) Just a small update to a comment in the code, now that Meilisearch has new functionality that implements a feature we need. --- src/search-manager/data/api.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/search-manager/data/api.ts b/src/search-manager/data/api.ts index 0763000f55..28822071a6 100644 --- a/src/search-manager/data/api.ts +++ b/src/search-manager/data/api.ts @@ -473,9 +473,9 @@ export async function fetchTagsThatMatchKeyword({ attributesToSearchOn: ['tags.taxonomy', 'tags.level0', 'tags.level1', 'tags.level2', 'tags.level3'], attributesToRetrieve: ['tags'], limit, - // We'd like to use 'showMatchesPosition: true' to know exactly which tags match, but it doesn't provide the - // detail we need; it's impossible to tell which tag at a given level matched based on the returned _matchesPosition - // data - https://github.com/orgs/meilisearch/discussions/550 + // TODO: improve this - use 'showMatchesPosition: true' to know exactly which tags match. Previously it didn't + // provide the detail we need (https://github.com/orgs/meilisearch/discussions/550) but it has now been implemented + // in newer versions of Meilisearch. See https://github.com/meilisearch/meilisearch/pull/5005 which fixes it. }); const tagSearchKeywordsLower = tagSearchKeywords.toLocaleLowerCase();