Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove newrelic from dependencies; note system deps in README #35683

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

timmc-edx
Copy link
Contributor

We don't need a dependency on newrelic in edx-platform, since it's already brought in via edx-django-utils, which is where telemetry dependencies belong anyhow.

Ran make compile-requirements to apply changes to lockfiles.

(Additional context: We may end up DEPRing the direct dependencies in edx-django-utils as well and requiring deployers to install newrelic separately. In any case, there aren't any places in openedx code that is installed into the LMS or CMS that import newrelic directly.)

Also, update README to note system package dependencies that are required for installing edx-platform deps. I had to reinstall my laptop and ran into this again and wanted to actually document it this time.

We don't need a dependency on `newrelic` in edx-platform, since it's
already brought in via edx-django-utils, which is where telemetry
dependencies belong anyhow.

Ran `make compile-requirements` to apply changes to lockfiles.

(Additional context: We may end up DEPRing the direct dependencies in
edx-django-utils as well and requiring deployers to install newrelic
separately. In any case, there aren't any places in openedx code that is
installed into the LMS or CMS that import newrelic directly.)

Also, update README to note system package dependencies that are required
for installing edx-platform deps. I had to reinstall my laptop and ran
into this again and wanted to actually document it this time.
@timmc-edx timmc-edx merged commit 869b621 into master Oct 21, 2024
49 checks passed
@timmc-edx timmc-edx deleted the timmc/no-nr branch October 21, 2024 18:15
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Ian2012 pushed a commit to eduNEXT/edx-platform that referenced this pull request Oct 22, 2024
…penedx#35683)

We don't need a dependency on `newrelic` in edx-platform, since it's
already brought in via edx-django-utils, which is where telemetry
dependencies belong anyhow.

Ran `make compile-requirements` to apply changes to lockfiles.

(Additional context: We may end up DEPRing the direct dependencies in
edx-django-utils as well and requiring deployers to install newrelic
separately. In any case, there aren't any places in openedx code that is
installed into the LMS or CMS that import newrelic directly.)

Also, update README to note system package dependencies that are required
for installing edx-platform deps. I had to reinstall my laptop and ran
into this again and wanted to actually document it this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants