-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove newrelic from dependencies; note system deps in README #35683
Conversation
We don't need a dependency on `newrelic` in edx-platform, since it's already brought in via edx-django-utils, which is where telemetry dependencies belong anyhow. Ran `make compile-requirements` to apply changes to lockfiles. (Additional context: We may end up DEPRing the direct dependencies in edx-django-utils as well and requiring deployers to install newrelic separately. In any case, there aren't any places in openedx code that is installed into the LMS or CMS that import newrelic directly.) Also, update README to note system package dependencies that are required for installing edx-platform deps. I had to reinstall my laptop and ran into this again and wanted to actually document it this time.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
…penedx#35683) We don't need a dependency on `newrelic` in edx-platform, since it's already brought in via edx-django-utils, which is where telemetry dependencies belong anyhow. Ran `make compile-requirements` to apply changes to lockfiles. (Additional context: We may end up DEPRing the direct dependencies in edx-django-utils as well and requiring deployers to install newrelic separately. In any case, there aren't any places in openedx code that is installed into the LMS or CMS that import newrelic directly.) Also, update README to note system package dependencies that are required for installing edx-platform deps. I had to reinstall my laptop and ran into this again and wanted to actually document it this time.
We don't need a dependency on
newrelic
in edx-platform, since it's already brought in via edx-django-utils, which is where telemetry dependencies belong anyhow.Ran
make compile-requirements
to apply changes to lockfiles.(Additional context: We may end up DEPRing the direct dependencies in edx-django-utils as well and requiring deployers to install newrelic separately. In any case, there aren't any places in openedx code that is installed into the LMS or CMS that import newrelic directly.)
Also, update README to note system package dependencies that are required for installing edx-platform deps. I had to reinstall my laptop and ran into this again and wanted to actually document it this time.