Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

CSS refactor #72

Closed
4 tasks done
Tracked by #71
Carlos-Muniz opened this issue Mar 22, 2022 · 2 comments · Fixed by #83
Closed
4 tasks done
Tracked by #71

CSS refactor #72

Carlos-Muniz opened this issue Mar 22, 2022 · 2 comments · Fixed by #83

Comments

@Carlos-Muniz
Copy link
Contributor

Carlos-Muniz commented Mar 22, 2022

We were probably the last ones to use the old edx theme from Paragon (which helped us achieve the Studio look faster), but it's now gone, leaving many boxes and buttons unstyled. Refactor the styling so that it no longer uses the included vendor CSS, instead relying as much as possible on Paragon.

Acceptance criteria

  • No page relies on vendor/studio.scss, vendor/normalize.scss or vendor/overrides.scss, but the general page layout is preserved. (For instance, buttons should be where existing users expect them to be.)
  • Styling of individual page elements need not be preserved, but elements should be converted to their closest Paragon equivalents.
  • If no Paragon component exists to replace legacy code, a new one should be create locally with a mind to eventually contribute it as a new one (or an update to an existing one).
  • src/vendor is completely removed
@Carlos-Muniz
Copy link
Contributor Author

Carlos-Muniz commented Apr 6, 2022

The guiding principle is:

  • Make the .scss in vendor/ as simple as possible by using vanilla paragon.
  • Make everything consistent, not perfect.

@Carlos-Muniz Carlos-Muniz removed their assignment May 26, 2022
@arbrandes arbrandes transferred this issue from openedx/wg-frontend Sep 30, 2022
@arbrandes arbrandes changed the title A CSS makeover: we were probably the last ones to use the old edx theme from Paragon (which helped us achieve the Studio look faster), but it's now gone, leaving many boxes and buttons unstyled. CSS refactor Sep 30, 2022
@arbrandes
Copy link
Contributor

@brian-smith-tcril, I've listed some acceptance criteria for us to discuss. The idea is for you to tackle this following the merge of #70.

@arbrandes arbrandes moved this from Needs refinement to Refined in Frontend Working Group Oct 17, 2022
@arbrandes arbrandes moved this to To Do - Backlog in Axim Engineering Tasks Oct 17, 2022
@arbrandes arbrandes moved this from To Do - Backlog to To Do - Prioritized for Current Sprint in Axim Engineering Tasks Oct 17, 2022
@arbrandes arbrandes linked a pull request Oct 31, 2022 that will close this issue
Repository owner moved this from To Do - Prioritized for Current Sprint to Done in Axim Engineering Tasks Oct 31, 2022
Repository owner moved this from Refined to In progress in Frontend Working Group Oct 31, 2022
@arbrandes arbrandes moved this from In progress to Closed in Frontend Working Group Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants