Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetNodeID failed for node #493

Closed
aep opened this issue Dec 4, 2023 · 6 comments
Closed

GetNodeID failed for node #493

aep opened this issue Dec 4, 2023 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug

Comments

@aep
Copy link
Contributor

aep commented Dec 4, 2023

when adding a node to StorageClass.allowedTopologies , nothing appears to create the matching zfsnode.zfs.openebs.io

the openebs-zfs-node pod is started but crashes with

F1204 13:06:11.157906       1 volume.go:92] GetNodeID failed for node=uca3k err: failed to get the node uca3k

in testing, this recovers when deleting all pvc and storageclass.

@sinhaashish
Copy link
Member

Can you please check PR #451 . It has the way how to set the labels for node.

@aep
Copy link
Contributor Author

aep commented Mar 19, 2024

closing because i never reproduced it

@aep aep closed this as completed Mar 19, 2024
@aep
Copy link
Contributor Author

aep commented May 19, 2024

reopening since it re-appeared when adding a node to an existing cluster.

i manually labeled the node as

      openebs.io/nodeid: archive
      openebs.io/nodename: archive

but that did nothing

looking at the code i'm not even sure why that would be related

https://github.com/openebs/zfs-localpv/blob/763ff6de8cdc2fee68b6cb005d6aca1e93732ddd/pkg/zfs/volume.go#L105C22-L105C30

the error returned here is just eaten, so we cant see the cause

@aep aep reopened this May 19, 2024
aep added a commit to aep/zfs-localpv that referenced this issue May 19, 2024
this is issue openebs#493

when zfs-localpv is broken due to an k8s api issue,
it just says 'GetNodeID failed for node'.
this change adds the actual api error

Signed-off-by: Arvid E. Picciani <[email protected]>
aep added a commit to aep/zfs-localpv that referenced this issue May 19, 2024
Fixes issue openebs#493

when zfs-localpv is broken due to an k8s api issue,
it just says 'GetNodeID failed for node'.
this change adds the actual api error

Signed-off-by: Arvid E. Picciani <[email protected]>
Abhinandan-Purkait pushed a commit that referenced this issue May 22, 2024
Fixes issue #493

when zfs-localpv is broken due to an k8s api issue,
it just says 'GetNodeID failed for node'.
this change adds the actual api error

Signed-off-by: Arvid E. Picciani <[email protected]>
@Abhinandan-Purkait Abhinandan-Purkait added the kind/bug Categorizes issue or PR as related to a bug label Jun 6, 2024
@avishnu
Copy link
Member

avishnu commented Oct 1, 2024

@aep were you able to figure out the reason once your fix went in?

@aep
Copy link
Contributor Author

aep commented Oct 1, 2024

Yes. Showing the actual error allowed me to find out it's a K8s API server issue. This can be closed.

@aep aep closed this as completed Oct 1, 2024
@avishnu
Copy link
Member

avishnu commented Oct 1, 2024

Glad to know it helped !!
Would you be kind enough to get added as an OpenEBS Adopter here? openebs/openebs#2719
Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug
Projects
None yet
Development

No branches or pull requests

4 participants