Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle removal of etcd.initialClusterState during helm upgrade in upgrade-job #1735

Open
niladrih opened this issue Sep 12, 2024 · 0 comments · May be fixed by openebs/mayastor-extensions#595
Open

Handle removal of etcd.initialClusterState during helm upgrade in upgrade-job #1735

niladrih opened this issue Sep 12, 2024 · 0 comments · May be fixed by openebs/mayastor-extensions#595
Assignees
@niladrih
Labels
Upgrade Upgrade infra or dependency

Comments

@niladrih
Copy link
Member

niladrih commented Sep 12, 2024 •
edited
Loading

Ref: openebs/mayastor-extensions#536

The upgrade-job, as of 2.7.0 reuses all of the existing helm values from the source chart. The removal of the parameter from the values.yaml would mean that during upgrade that value has to be forcibly removed when moving to 2.7.0+ versions. This needs to be handled somehow.

If there is no new design changes to upgrade, a new entry to the helm::values.rs module is required which explicitly removes the value from the values set. This might also be required even if helm's --reset-then-reuse-values flag is used, as previous upgrade-jobs would have used the -f values.yaml option during upgrade and would have explicitly set ALL of the source chart's values (and they would be now visible on helm get values output).
@niladrih niladrih self-assigned this Sep 12, 2024
@niladrih niladrih added the Upgrade Upgrade infra or dependency label Sep 12, 2024
niladrih added a commit to openebs/mayastor-extensions that referenced this issue Jan 6, 2025
@niladrih
fix(upgrade): remove etcd.initialClusterState from helm values
ba2b70b 
Fixes openebs/mayastor#1735

This removes the helm value for the key etcd.initialClusterState for all
versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3.

Signed-off-by: Niladri Halder <[email protected]>
@niladrih niladrih linked a pull request Jan 6, 2025 that will close this issue
Open
niladrih added a commit to openebs/mayastor-extensions that referenced this issue Jan 6, 2025
@niladrih
fix(upgrade): remove etcd.initialClusterState from helm values
9a67f73 
Fixes openebs/mayastor#1735

This removes the helm value for the key etcd.initialClusterState for all
versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3.

Signed-off-by: Niladri Halder <[email protected]>
bors-openebs-mayastor bot pushed a commit to openebs/mayastor-extensions that referenced this issue Jan 8, 2025
@niladrih
chore(bors): merge pull request #595
2e4a940 
595: fix(upgrade): remove etcd.initialClusterState from helm values r=niladrih a=niladrih

Fixes openebs/mayastor#1735

This removes the helm value for the key etcd.initialClusterState for all versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3.

Co-authored-by: Niladri Halder <[email protected]>
niladrih added a commit to openebs/mayastor-extensions that referenced this issue Jan 8, 2025
@niladrih
fix(upgrade): remove etcd.initialClusterState from helm values
72a15d7 
Fixes openebs/mayastor#1735

This removes the helm value for the key etcd.initialClusterState for all
versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3.

Signed-off-by: Niladri Halder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niladrih niladrih

Labels
Upgrade Upgrade infra or dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(upgrade): remove etcd.initialClusterState from helm values openebs/mayastor-extensions
1 participant
@niladrih