Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable_fast_timestep #851

Open
Tracked by #548
neal2164 opened this issue Jan 3, 2025 · 1 comment
Open
Tracked by #548

enable_fast_timestep #851

neal2164 opened this issue Jan 3, 2025 · 1 comment
Labels
algo Add new algorithm or improve old one

Comments

@neal2164
Copy link

neal2164 commented Jan 3, 2025

DI-engine/ding/policy/r2d2.py

Line 320 in f60b377

inputs = {'obs': data['burnin_nstep_obs'], 'enable_fast_timestep': True}

Seems this key is used in many places but has no effect.
@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Jan 3, 2025
@PaParaZz1 PaParaZz1 mentioned this issue Jan 13, 2025
Open
@puyuan1996
Copy link
Collaborator

In the latest version of DI-engine, the enable_fast_timestep feature is indeed no longer being utilized. It seems to be legacy code from earlier updates that has not yet been removed. We plan to submit a PR)to delete it in the future. Thank you for pointing this out! If you have any other questions, please don’t hesitate to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
algo Add new algorithm or improve old one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PaParaZz1 @puyuan1996 @neal2164