Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace coedit with DOM-based version #195

Closed
ccotter opened this issue Jul 1, 2012 · 5 comments
Closed

Replace coedit with DOM-based version #195

ccotter opened this issue Jul 1, 2012 · 5 comments
Assignees
Labels
Milestone

Comments

@ccotter
Copy link
Member

ccotter commented Jul 1, 2012

In response to the issues associated with the coeditor (#166, #167, #183, #185), I've created a new version of the coeditor. Technically, the major change is that the rich text data is stored as a DOM tree as opposed to raw HTML text. This change helps performance, improves functionality, and eliminates the impossibility of the raw HTML version of converging to valid HTML (see #185).

Currently, the master branch of cowebx has two editor demos: cowebx-apps/coedit and cowebx-apps/coeditDom. The new coeditDom demo shall be tested for stability, correctness and will eventually replace coedit. This issue will track the progress of this transition.

@ghost ghost assigned ccotter Jul 1, 2012
@ccotter
Copy link
Member Author

ccotter commented Jul 2, 2012

The developer server has update-to-date versions of the new editor:

http://vhost1628.developer.ihost.com:8080/coeditDom

@ccotter
Copy link
Member Author

ccotter commented Jul 23, 2012

The only thing left before the new coedit can be seriously considered is keeping track of user's cursor. Right now, no attempt is made to save the cursor position when another remote user is editing the document. Unfortunately, I don't think we can use rangy. I'm trying to devise a solution though...

@ccotter
Copy link
Member Author

ccotter commented Jul 24, 2012

My solution now is to have every client track each other's cursor positions/range selections. Tracking each selection range is the best way I can track a local client's selection range (I couldn't figure out how to track only a local client's range).

@ccotter
Copy link
Member Author

ccotter commented Jul 31, 2012

The current status is that I don't think I'll easily be able to track cursor selection ranges...so I'm putting this issue on hold. Without the ability to remember cursor position, we should not replace the old editor with this tree based editor. In the meantime, I'll branch off the new editor, and remove it from the master branch.

I do, however, have some ideas for improving the functionality of the old editor, so I'll focus on that.

@ccotter
Copy link
Member Author

ccotter commented Aug 1, 2012

I've removed coeditDom and the matching widget code from cowebx master. cowebx branch issue185 holds the coeditDom code in case we ever wish to revisit it.

@ccotter ccotter closed this as completed Aug 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant