Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_testCreatePanModelsm #2343

Closed
wants to merge 6 commits into from
Closed

Conversation

rosieluo2021
Copy link
Contributor

Please include a short description of enhancement here

I hereby confirm that I have:

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

(Note: You may replace [ ] with [X] to check the box)

@farid-zare
Copy link
Collaborator

Hi Rosie,
Thanks for your contribution.
I think we can't add a user prompt section in test functions such as the one you added to the "testCreatePanModels.m". As the tests are going to be part of an automated continues integration, there should be no user prompt requirement for running a test. I think we have to revert that commit until we find a better solution for panModels testing.

@rosieluo2021
Copy link
Contributor Author

rosieluo2021 commented Oct 5, 2024 via email

@rmtfleming
Copy link
Member

resolve conflicts

@rmtfleming rmtfleming closed this Oct 6, 2024
@farid-zare
Copy link
Collaborator

Changes to "testCreatePanModels" are not confirmed and should be removed.
Almut is working on "testCreatePanModels" to resolve its problem

commit b8c9d66 should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants