Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtokens pallet didn't support the PriceForSiblingDelivery #1008

Open
sfffaaa opened this issue Sep 23, 2024 · 1 comment
Open

Xtokens pallet didn't support the PriceForSiblingDelivery #1008

sfffaaa opened this issue Sep 23, 2024 · 1 comment

Comments

@sfffaaa
Copy link

sfffaaa commented Sep 23, 2024

Hi, when I try to induce the PriceForSiblingParachainDelivery into our parachain, the related extrinsic in xtoken's pallet cannot work because of NotHoldingFees. I guess the reason is the design of the Xtokens isn't compatible with the concept of PriceForSiblingDelivery. Do I understand right? If so, do you have any suggestions about that?

pub type PriceForSiblingParachainDelivery =                                                                                      
    ExponentialPrice<SelfReserveLocation, BaseDeliveryFee, TransactionByteFee, XcmpQueue>;                                       
                                                                                                     
impl cumulus_pallet_xcmp_queue::Config for Runtime {                                                                             
...
    type PriceForSiblingDelivery = PriceForSiblingParachainDelivery;                                                             
...
}
@xlc
Copy link
Member

xlc commented Sep 23, 2024

We kinda need XCM v5 with improved fee mechanism to make it work paritytech/polkadot-sdk#5420
Also I would like to put xtokens on maintenance mode and people should migrate to xcm-pallet for the use cases that xtokens doesn't support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants